From owner-freebsd-stable@FreeBSD.ORG Tue Apr 21 07:00:58 2009 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8BDE7106564A for ; Tue, 21 Apr 2009 07:00:58 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 5E5FA8FC1C for ; Tue, 21 Apr 2009 07:00:58 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 5AF1331B193; Tue, 21 Apr 2009 02:42:28 -0400 (EDT) Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute2.internal (MEProxy); Tue, 21 Apr 2009 02:42:28 -0400 X-Sasl-enc: JCumM/aW543fTo2lAksUCrcg3At+OaZuOCndGHDcNO/q 1240296147 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id 6B684538D8; Tue, 21 Apr 2009 02:42:27 -0400 (EDT) Message-ID: <49ED6AD2.4010006@incunabulum.net> Date: Tue, 21 Apr 2009 07:42:26 +0100 From: Bruce Simpson User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Dennis Melentyev References: <49E6DB25.2010601@sippysoft.com> <49E6FF8F.4070403@sippysoft.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@freebsd.org, Sam Leffler , "current@freebsd.org" , Maxim Sobolev Subject: Re: kernel compile fails without AH_SUPPORT_AR5416 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 07:00:58 -0000 Hi, Looks like I'm late to the party. I was responsible for committing these ath(4) changes to RELENG_7. I can't remember if I tested the kernel compile without the AH_SUPPORT_AR5416 option or not, I have been so incredibly busy. Dennis Melentyev wrote: > 2009/4/16 Maxim Sobolev : > >> Dennis Melentyev wrote: >> >>> Could be worth an entry in UPDATING and/or explicitly added to GENERIC. >>> >> My point is that if the option is mandatory for compiling ath(4) driver, >> then there is no point in having this option in the first place. >> > > Well, fair. > +1 from me :). > > So is there a consensus that this seems to break the build for folk who do not need this option? If so I can see about committing the necessary changes to turn this option on by default. I needed the option for what I was trying to do. Of course if someone already has a patch for that, that will help, as I don't have a lot of free time at the moment but can certainly commit a quick fix if someone already has one. thanks, BMS