From owner-cvs-all@FreeBSD.ORG Fri Jan 26 13:32:39 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C74DC16A402; Fri, 26 Jan 2007 13:32:39 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.t-hosting.hu (server.t-hosting.hu [217.20.133.7]) by mx1.freebsd.org (Postfix) with ESMTP id 779A013C458; Fri, 26 Jan 2007 13:32:37 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.t-hosting.hu (Postfix) with ESMTP id 7EBFE9C3038; Fri, 26 Jan 2007 14:32:35 +0100 (CET) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.t-hosting.hu ([127.0.0.1]) by localhost (server.t-hosting.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ciyBpSfc8Rel; Fri, 26 Jan 2007 14:32:29 +0100 (CET) Received: from [192.168.2.186] (catv-50635cb6.catv.broadband.hu [80.99.92.182]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.t-hosting.hu (Postfix) with ESMTP id C7ABF9C3036; Fri, 26 Jan 2007 14:32:28 +0100 (CET) Message-ID: <45BA02E6.2050405@FreeBSD.org> Date: Fri, 26 Jan 2007 14:32:22 +0100 From: Gabor Kovesdan User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: Alexander Leidinger References: <200701252300.l0PN0rsh064780@repoman.freebsd.org> <20070126131258.30fic24gao8o44gc@webmail.leidinger.net> In-Reply-To: <20070126131258.30fic24gao8o44gc@webmail.leidinger.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Eric P. Scott" , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/linux-nx-client Makefile distinfo pkg-plist ports/net/linux-nx-client/files patch-nxclient-admin.desktop patch-nxclient-help.desktop patch-nxclient-wizard.desktop patch-nxclient.desktop X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2007 13:32:39 -0000 Alexander Leidinger schrieb: > Quoting Gabor Kovesdan (from Thu, 25 Jan 2007 > 23:00:53 +0000 (UTC)): > >> gabor 2007-01-25 23:00:52 UTC >> >> FreeBSD ports repository >> >> Modified files: >> net/linux-nx-client Makefile distinfo pkg-plist >> Removed files: >> net/linux-nx-client/files patch-nxclient-admin.desktop >> patch-nxclient-help.desktop >> patch-nxclient-wizard.desktop >> patch-nxclient.desktop >> Log: >> - Update to 2.1.0 >> - Move to LINUXBASE > > I had a look at the changes and the entire plist. I think this belongs > into localbase instead. linuxbase is reserved for infrastructure ports > (e.g. libs). Stuff which is used directly by users is supposed to go > to localbase. The plist shows systems independend stuff in "ordianary" > directories, and the linux object specific stuff in a directory > (lib/linux-nx-client/) which makes it very hard to mistake it as > FreeBSD native stuff (it also contains some pictures, which don't > belong here but into share instead, but this is not high priority > stuff to fix). So I suggest to move it into localbase instead. > >> - Add USE_LDCONFIG > > This is not ncessary here at all, as the linux libs are private ones > and are not in the default search path of the linux ldconfig. > Ah ok, for me the only reason for moving it to LINUXBASE was using linux ldconfig, but since it's not required I can easily move it to LOCALBASE, thanks for pointing this out. I'll fix soon. Regards, Gabor