Date: Fri, 26 Jan 2007 14:32:22 +0100 From: Gabor Kovesdan <gabor@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: "Eric P. Scott" <eps+pbug0611@ana.com>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/linux-nx-client Makefile distinfo pkg-plist ports/net/linux-nx-client/files patch-nxclient-admin.desktop patch-nxclient-help.desktop patch-nxclient-wizard.desktop patch-nxclient.desktop Message-ID: <45BA02E6.2050405@FreeBSD.org> In-Reply-To: <20070126131258.30fic24gao8o44gc@webmail.leidinger.net> References: <200701252300.l0PN0rsh064780@repoman.freebsd.org> <20070126131258.30fic24gao8o44gc@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Leidinger schrieb: > Quoting Gabor Kovesdan <gabor@FreeBSD.org> (from Thu, 25 Jan 2007 > 23:00:53 +0000 (UTC)): > >> gabor 2007-01-25 23:00:52 UTC >> >> FreeBSD ports repository >> >> Modified files: >> net/linux-nx-client Makefile distinfo pkg-plist >> Removed files: >> net/linux-nx-client/files patch-nxclient-admin.desktop >> patch-nxclient-help.desktop >> patch-nxclient-wizard.desktop >> patch-nxclient.desktop >> Log: >> - Update to 2.1.0 >> - Move to LINUXBASE > > I had a look at the changes and the entire plist. I think this belongs > into localbase instead. linuxbase is reserved for infrastructure ports > (e.g. libs). Stuff which is used directly by users is supposed to go > to localbase. The plist shows systems independend stuff in "ordianary" > directories, and the linux object specific stuff in a directory > (lib/linux-nx-client/) which makes it very hard to mistake it as > FreeBSD native stuff (it also contains some pictures, which don't > belong here but into share instead, but this is not high priority > stuff to fix). So I suggest to move it into localbase instead. > >> - Add USE_LDCONFIG > > This is not ncessary here at all, as the linux libs are private ones > and are not in the default search path of the linux ldconfig. > Ah ok, for me the only reason for moving it to LINUXBASE was using linux ldconfig, but since it's not required I can easily move it to LOCALBASE, thanks for pointing this out. I'll fix soon. Regards, Gabor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45BA02E6.2050405>