From owner-svn-src-head@freebsd.org Sat Apr 22 21:19:51 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF4AFD4B549; Sat, 22 Apr 2017 21:19:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 93419210; Sat, 22 Apr 2017 21:19:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-it0-x243.google.com with SMTP id e132so6515117ite.2; Sat, 22 Apr 2017 14:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=ECcEhPwZup27ttw1zWq+ZYl4ckLCU8N3E93V5xsOQSs=; b=ToZQj4YTH+JHm45jEhXb6cZ6n8+mgC6iN47gPhWa1JVFr8PT2Xwb2NHUpXOtdKAhM5 SeiX2PHsJZmjiLgrbQod6RIbbb5TgedpAuawJGhqHu0QrW0w/S/oJQ/pZuNq60DKcnk8 TxAU6RVh1UYqi8BRnqtzdMZdrARO5357Px3ljdc1hABPhVcdu9n2gs07RzOmKNTC4D7I 7l4TBvO6LOoxLNiDa1D7Q4e6l+m0/e4DzkSSJcILKg0A+lspccH8EdgpR7sNfz9z3wcs Ju5UowEQo9Qbi8l9xKlhB6vVS1oC5/1eA0gsgVck3ZvAxaBPhGsnzUam/TRde6dQxl31 lI0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=ECcEhPwZup27ttw1zWq+ZYl4ckLCU8N3E93V5xsOQSs=; b=tMI9Uri3LJbgD7xVZtvjTP3+549u/9X6cZAcfp1A4tL3jkCZ98GF1Bpujz40DfkldA e/0rPiUQ6OnWV6KhPpqHn5JKBC63cw70kNAjjC2B5hgd6BhW4OO4rjqSYhtGt1JAPxXd QAGfTIb/np72qjyHv0NvDYlGrfuL/OrH+EdX2kbtVrEu1xQodB5wkfbevn+5UMShqPiJ HD7b6faAoq/L0Ljv5EBhv+sosJJ7R8OE00TfjvpQSDU01aUG1xnNmBbRCfuYBILBkCJ2 iBCw5AfCWkQdT0CM05+bh0JHSuYDD2B8o10Op9xGkNiwCv4jR0MlgeoiAcngQhVzFvN6 rB9w== X-Gm-Message-State: AN3rC/54dlSxvWn8ts3xAuLutEJcEHAy85gOXWP0RLvfCDoAuT1iGu1L yX0SpFibBijjqd9MbBY= X-Received: by 10.84.217.215 with SMTP id d23mr23301677plj.59.1492895990677; Sat, 22 Apr 2017 14:19:50 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c83sm22897272pfd.113.2017.04.22.14.19.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Apr 2017 14:19:49 -0700 (PDT) Subject: Re: svn commit: r317290 - head/tools/regression/geom_gpt Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_E8EF0A77-B3FC-48AE-914B-B14721A7887F"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201704222109.v3ML9ahr047899@pdx.rh.CN85.dnsmgr.net> Date: Sat, 22 Apr 2017 14:19:48 -0700 Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201704222109.v3ML9ahr047899@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2017 21:19:51 -0000 --Apple-Mail=_E8EF0A77-B3FC-48AE-914B-B14721A7887F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 22, 2017, at 14:09, Rodney W. Grimes = wrote: =E2=80=A6 > I had seen that already when I made my post, that docuement is not = going > to stop someone from going "Oh, these are out of order I am going to = sort > them since I am here" They well then probably have issues due to your = next > statement about WARNS and go hum, what is that all about. And either > investigate and hopefully find the right thing, or do more wrong = things. >=20 > When #includes are out of order for good reason the source code file = should > be market as such and not dependend on the near 0 likelyhood someone > is going to go read a man page to find out why. The issue you=E2=80=99re noting is no different from someone = removing/shuffling around another header in the C file. If someone does = that, the least they need to do is build test their changes, and ideally = they should runtime test the changes as well. WARNS is insurance against someone sorting headers and things breaking = again, because gctl_dump will not be defined (per the compiler message = noted in the PR). At which point the party should do =E2=80=9Cman = gctl_dump=E2=80=9D and see the comment about stdio.h being required for = it: $ man gctl_dump ... SYNOPSIS /* stdio.h is only required for `gctl_dump` */ #include #include =E2=80=A6 Put differently, this is no different of an issue than anything else and = I really don=E2=80=99t see the value in adding a comment stating that = the order is such because of gctl_dump needing stdio.h to be = #include=E2=80=99d first. Thanks, -Ngie --Apple-Mail=_E8EF0A77-B3FC-48AE-914B-B14721A7887F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY+8j1AAoJEPWDqSZpMIYVSz8QAMyDE0nHWs6O3oe+3SyYovnJ Yhqz3/FxWeId4bImQIdwMJNM6CroYHY3DkGWfnO8l7RPeKQv5R1a3sA5UvB/rPUS oBZGWwEPAKlUL+TttI0rnNKCRSP6XyttknU2wiccpFAloBXD2aL5XTD8sbOdTgUo Pu7t8NEXCqtG5PmDKtc5a6vl+fNl0ev3srJDAecX9J9DdaeoNAcltWOBN80HcbVU wS3mGW3KjPAohl/cwKUyig3iVeuSZ0f0arSKVymPtFWN+4MiV5Rfifl98UrreDD5 +JpzuTMacCWZhCPlhOvohymOMFr28/VW2AOXXTJY+JEvN0yCmgNBsTYy00oZs5+I PO6a5n/and7eRx/UmcfnxcdG639930kilmV8x3oKDzYSSz8RDCXKQAC0z1EdfF09 lkk93jQOeSvxWqi1N9rupzYuATTHS0nUWIf1Lrht1aJa+Fz4EVMEMKx3ShVW3KGK L0v4dYGT5lveTFOQ6xjRKx2wjKLP3XhDx9d29lReOZE/iIxXi/EZdmLzQ2LsvMVr pyDAF3YGQSNtyYq+MEGpINaPNNYWb6B9TGVlqgBBneaIYOeB9Mj8fpilvJK5uT35 0A9I3gvzpGTZeypMbo10vg3y73TxrLh5hX9OWLLVJHxqFdoDhp+rLpCB3CEtJTRB kQ6E2RGZYnENvRkgmn4v =PXbU -----END PGP SIGNATURE----- --Apple-Mail=_E8EF0A77-B3FC-48AE-914B-B14721A7887F--