From owner-svn-src-all@freebsd.org Wed Jan 13 01:23:30 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71C15A6E661 for ; Wed, 13 Jan 2016 01:23:30 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0503A1205 for ; Wed, 13 Jan 2016 01:23:30 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x233.google.com with SMTP id f206so274976293wmf.0 for ; Tue, 12 Jan 2016 17:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Pv2iUyd8zYbUg5jTqbUdPL2/nXzD/mL2nbkjgxnDuGY=; b=XejkHDkWtzahfysZ17zZOJjfzMwJm20HKfFDbr3hpkKwXvMCzY8yO1nNFkdyw8oXN1 Dfr1xXLzBoTuoJY6a+Y1H0H7GqLNIlDJxQtv3FqkLP7i1HFmyrVaBCPNbz/UjlktXa3G up+bpPDNcZNk9ZcUJXUSVBb0y4ABReQObkDnxTLzpAN2nnEcneam0924U3ER6zcH104M wnz+F3yIgHwqlIA/lqaOj86louO60q4/oCLP5FOwxWG8aDemypdmZ4kqVCGxD8iTSkYx LU/IXLVNUTGAp3erU21gni2h6amX4HZ7CwGs3IDGAVI7QcDytk+1h7GMp9stUFJmtgmE towg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=Pv2iUyd8zYbUg5jTqbUdPL2/nXzD/mL2nbkjgxnDuGY=; b=Uf1DpOALZ24loR3BY9dSvF1s1Ivmxkwd5wgpnLVRkdMGxCRh/D0PLbcbMAq00Pw9Ig d99Lgdom7/aeU+nP+Pl7zaMpDzYyOWzJUg+ehC3xgd84VdsBoV7gPlP3MRWvKCXMMnAt EdlBCONlonMY099SNt6+/llAFwH6d3r2pNoPrJ09QnLTWPIL0+nWE+sZWHN6OBxrGkKY p5Cz3BZsiV2k58zRylYi/Q1yb/65Zp0j12SH/pygjAGeXfC2XD+66m5gXOwRoWZhgtL4 hLCWbsfBsLMbmefOOXb0Co5gNTc88oBq1wM5ZDov39vl3QYSj0EP7q/7MqsNXAq5vIlE tmGg== X-Gm-Message-State: ALoCoQmBk9xOgdn3tQVhCyNSZwgczZP7PjiYT1lsSzaJOGbRn8w0zT70jP3V1qnk4DWGFjYXDL+byFzXdvaS5HuJ4k0ebBFQ3g== X-Received: by 10.28.184.76 with SMTP id i73mr21508519wmf.43.1452648208535; Tue, 12 Jan 2016 17:23:28 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id c26sm19934982wmi.21.2016.01.12.17.23.27 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 12 Jan 2016 17:23:27 -0800 (PST) Subject: Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64 i... To: Allan Jude , NGie Cooper , Ian Lepore References: <201601120217.u0C2HdBC089684@repo.freebsd.org> <1452645668.46848.34.camel@freebsd.org> <56959DA7.9050206@freebsd.org> <1452646442.46848.37.camel@freebsd.org> <5695A40C.6050306@freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Steven Hartland Message-ID: <5695A720.3000302@multiplay.co.uk> Date: Wed, 13 Jan 2016 01:23:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5695A40C.6050306@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 01:23:30 -0000 On 13/01/2016 01:10, Allan Jude wrote: > On 2016-01-12 20:05, NGie Cooper wrote: >> On Tue, Jan 12, 2016 at 4:54 PM, Ian Lepore wrote: >> ... >>> For several reasons. The fact that gcc isn't the default compiler >>> doesn't mean that it's okay for code to not compile with gcc; it's >>> still a supported compiler for arm. >> >> Agreed. It also makes things messier when MFCing changes if it doesn't >> work with gcc. >> Thanks, >> -NGie >> > > If it is a supported compiler, maybe we need a tinderbox option that > compiles ARM with gcc, to catch cases like this. > Yer we really should. I explicitly ran tinderbox on these changes in order to ensure all the bases where covered, if there are additional options not run by tinderbox but are supported then we really need add them otherwise we're just assuming everyone knows to manually test additional configurations which is never going to work. Regards Steve