From owner-freebsd-ports@FreeBSD.ORG Sun Jun 11 06:35:58 2006 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 254CF16A477 for ; Sun, 11 Jun 2006 06:35:58 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id A1AD843D45 for ; Sun, 11 Jun 2006 06:35:57 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 8888 invoked by uid 399); 11 Jun 2006 06:35:57 -0000 Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 11 Jun 2006 06:35:57 -0000 Message-ID: <448BB9CA.8050901@FreeBSD.org> Date: Sat, 10 Jun 2006 23:35:54 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5.0.4 (X11/20060604) MIME-Version: 1.0 To: Sam Lawrance References: <448B0127.1040107@isc.org> <448B655E.70003@FreeBSD.org> <448B6EDF.4040401@isc.org> <448B74BF.20203@FreeBSD.org> <64E1E60A-9AFF-4C93-A8D1-D6CC8B1BCBDC@brooknet.com.au> In-Reply-To: <64E1E60A-9AFF-4C93-A8D1-D6CC8B1BCBDC@brooknet.com.au> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Ports , Boris Kovalenko , Peter Losher Subject: Re: FreeBSD Port: net/quagga X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jun 2006 06:35:58 -0000 Sam Lawrance wrote: > In that case we should remove the check from portlint, until > USE_RC_ORDER is no longer required by supported systems. Otherwise it's > just another confusing portlint warning. I disagree. I would rather have to change a small number of ports back that really do need it, than to continue having ports that don't need it needlessly spam /etc/rc.d. I maintain a lot of ports that have weirdness in them that portlint doesn't like. It's a tool, not a report card. :) > The port author removed it because portlint said it was deprecated. Even if that is true, it sparked a lively discussion, so it's not all bad. > Can USE_RC_ORDER still be used on all supported FreeBSD versions without > negative effect? As far as I know, yes, but that's not really the point. For those systems that are past the local_startup merge, it's better to have them install their ports startup script in $PREFIX, since that is the direction that all of this is ultimately moving towards. I have no objection to preserving legacy behavior for those ports (and systems) that really do need it, but those that don't shouldn't be hamstrung by it. > If there is a need to conditionalize behaviour on > OSVERSION, it could be handled in bsd.port.mk (depending on how many > ports need it, really). I agree with both parts of your statement here. My intent was to provide a solution that would work immediately to make life a little easier on the port author. If this really does turn out to be a larger problem, then a larger solution is a SMOP. Doug -- This .signature sanitized for your protection