From nobody Thu Oct 26 20:29:03 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SGcp80cHKz4yFMr; Thu, 26 Oct 2023 20:29:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SGcp805cnz3RLW; Thu, 26 Oct 2023 20:29:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698352144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lAl2iyVubCbQXUQI6PfZsPDN9neZOktLTRDiz0TLt2Q=; b=jHavH+4rix87V/UVrrdRS7FzcTWSKHj2E4q/kJA79oMPMCSJN0ORRcTv86cfRqJn720X5f EzuQL++ic5heSCj7bSabIW81uXAHnH2UZ7y/ZiST7Vd3lDyxIh0viQRNC7eJwmtoU/QUVL XRXQfCdG/DMkd/2z541jahsrvPQedEtJn0LrHk2HXdQSWfojFuHTbd8r9HkxFxEjJ7iE7C ssFmafx6cXB/GZZ6rJjlwIhFfBxOQM4vqAqPNnjJaC72X1eYubqaFzE9It7Rk4sBXMjepo OOtmC/TP83D7DepKlbaHx5YmSSMoWmHioFLbmHzpNVczaQto18h9Z/bTZl5zdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698352144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lAl2iyVubCbQXUQI6PfZsPDN9neZOktLTRDiz0TLt2Q=; b=sWCx1qYfIG9PorAtRhIWAgzXCP3xtGWhgkWQJqZcrFDQL+M1G6T7HEcDfScOQYE/6SEG0J lelg12ffq/1yc4esokiX0bIfQ6hzd0pwDwl8CTtgkiZv0rbg9II1TG1yVIvFyxkRHS5umZ 4+HdRLMJvRE7UZ+BXMWw3R3p6JCMetp+GBHzBvCNyUF0onUvIeoT1NVLlC1q2Wiu3bseyV S+LUvJJr2WjmbeRMHo5gpYAhkKfOhZgWLrNYwPYPfABx605rl88Nz611H82h5jZECbW+as Fy+9myEi9F9gZfJnXQWWh57WY6vHHQAi1bOK4Yf4zqh/j2OX2cyV2E3c3eAwGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698352144; a=rsa-sha256; cv=none; b=ZJpfPuqYTMta3rKHQRyfN/sPfzcVwDX4PRy01w9I9d2vEcirUI60GqGoNZpb4b/WQkQOit G1r7tyj7t6rmtEEvUOPrkPMpgTtPs9PFUYfpS5hukIp6wO9AM63NP7WCrbi5oOaEert8EL zWsVhrKQ5EtGGnwml136ZxGOF0+S3NNGsCBuIbSUApDF4BwDX2NPSxDR9WDOpd1lFVTese qcb1N8RfQZQyjTGejeRooKmLz/a5P2lRMXUPpSktp/zqrSXkieGj4iaDgCtvdS2fJ3i04T JSESuGSZ5MdNf/VVXeoDOdBzmE0rxosPrlU4Sy9PVuXuQ+nYLIzQhi5zSI7A8Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SGcp76GGnzlj3; Thu, 26 Oct 2023 20:29:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39QKT3g7074206; Thu, 26 Oct 2023 20:29:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39QKT346074203; Thu, 26 Oct 2023 20:29:03 GMT (envelope-from git) Date: Thu, 26 Oct 2023 20:29:03 GMT Message-Id: <202310262029.39QKT346074203@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: abf5807ffc36 - releng/14.0 - bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS) List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: abf5807ffc36516976426a83d94caf135d3ea814 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=abf5807ffc36516976426a83d94caf135d3ea814 commit abf5807ffc36516976426a83d94caf135d3ea814 Author: Gleb Smirnoff AuthorDate: 2023-10-26 09:59:21 +0000 Commit: Mark Johnston CommitDate: 2023-10-26 20:28:23 +0000 bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS) ioctl(2)'s with integer argument shall pass command argument by value, not by pointer. The ioctl(2) manual page is not very clear about that. See sys/kern/sys_generic.c:sys_ioctl() near IOC_VOID. Approved by: re (gjb) Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D42366 Fixes: fd8b9c73a5a63a7aa438a73951d7a535b4f25d9a (cherry picked from commit f407a72a506d2630d60d9096c42058f12dff874e) (cherry picked from commit 6f1ccbd587907c5eaf05ddd77d1e9f5e16b7aedc) --- usr.sbin/bhyve/net_backends.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/net_backends.c b/usr.sbin/bhyve/net_backends.c index 99781cfdcbb6..de6afab53854 100644 --- a/usr.sbin/bhyve/net_backends.c +++ b/usr.sbin/bhyve/net_backends.c @@ -238,7 +238,7 @@ tap_init(struct net_backend *be, const char *devname, goto error; } - if (ioctl(be->fd, VMIO_SIOCSIFFLAGS, &up)) { + if (ioctl(be->fd, VMIO_SIOCSIFFLAGS, up)) { WPRINTF(("tap device link up failed")); goto error; }