Date: Thu, 14 Jan 2016 07:55 -0800 From: John Baldwin <jhb@freebsd.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: Steven Hartland <smh@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi Message-ID: <8690606.xvPx6EyIfQ@ralph.baldwin.cx> In-Reply-To: <F3E05332-F6B1-4685-812A-FD2BBB870075@gmail.com> References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <F3E05332-F6B1-4685-812A-FD2BBB870075@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, January 14, 2016 01:27:51 AM NGie Cooper wrote: >=20 > > On Jan 14, 2016, at 01:22, Steven Hartland <smh@FreeBSD.org> wrote:= > >=20 > > Author: smh > > Date: Thu Jan 14 09:22:01 2016 > > New Revision: 293903 > > URL: https://svnweb.freebsd.org/changeset/base/293903 > >=20 > > Log: > > Fix GCC warnings causing build failure after r293724 > >=20 > > Disable some compiler warnings for GCC (non-standard compiler) fix= ing > > build failures introduced by r293724, which enabled WARNS in the E= FI boot > > code, when compiling with none standard compiler (GCC). >=20 > Disabling warnings is wrong. Here=E2=80=99s how arm could be fixed: >=20 > $ svn diff sys/boot/ > Index: sys/boot/common/bootstrap.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/boot/common/bootstrap.h (revision 293877) > +++ sys/boot/common/bootstrap.h (working copy) > @@ -32,6 +32,7 @@ > #include <sys/types.h> > #include <sys/queue.h> > #include <sys/linker_set.h> > +#include <time.h> > =20 > /* > * Generic device specifier; architecture-dependant=20 > @@ -332,12 +333,8 @@ > extern struct arch_switch archsw; > =20 > /* This must be provided by the MD code, but should it be in the arc= hsw? */ > -void delay(int delay); > - The comment seems to be related to delay() so it should perhaps go as w= ell? --=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8690606.xvPx6EyIfQ>