From owner-freebsd-net@freebsd.org Fri Mar 16 14:49:00 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0AFACF547D9 for ; Fri, 16 Mar 2018 14:49:00 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward106o.mail.yandex.net (forward106o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F58B81DFE for ; Fri, 16 Mar 2018 14:48:58 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from mxback11j.mail.yandex.net (mxback11j.mail.yandex.net [IPv6:2a02:6b8:0:1619::84]) by forward106o.mail.yandex.net (Yandex) with ESMTP id CC086784089; Fri, 16 Mar 2018 17:48:43 +0300 (MSK) Received: from smtp4p.mail.yandex.net (smtp4p.mail.yandex.net [2a02:6b8:0:1402::15:6]) by mxback11j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id HgBVXoP4yI-mhHqn9uN; Fri, 16 Mar 2018 17:48:43 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1521211723; bh=Uylom3SOAdVyY5eXNz826m39OLXnSkLrMQndNY/6tgc=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=Il+GnvuuuTCdUfdCKMaQg2boWrM422pM60yUmpcTzg2PqikKHH4V5fNTFQJcK+Xgc nakeQnm0hugYMZoPxDbLKNaW+grTho5BZTRncglRgOZ9p2nxRV1fl6CM9ohd+zwjcz l3eGimwGnBTyW9SFHy8voUYIp4hXzNqk6Jg9N6bA= Received: by smtp4p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id d5hshxe5wl-mgSa8eoW; Fri, 16 Mar 2018 17:48:42 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1521211722; bh=Uylom3SOAdVyY5eXNz826m39OLXnSkLrMQndNY/6tgc=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=RAVj+5DZ9rY9/GKybZJxTw4mlxiUea5fB01CZRXH3JuPOcWhpA4LMFuxjWo3d7rdS DplVTv2OhW21z2OSFjwG2D/Cxc/RMlserFoRq9EJ9PgYoEMOV/Dm9JilJYo56NLOiH /pLz+AOe1e4b54ZJ0W8YZoRnQNPiziFn/2cLCZEc= Authentication-Results: smtp4p.mail.yandex.net; dkim=pass header.i=@yandex.ru Subject: Re: Does FreeBSD do proactive ARP refresh?,Re: Does FreeBSD do proactive ARP refresh? To: sthaug@nethelp.no Cc: freebsd-net@freebsd.org, melifaro@ipfw.ru References: <20180316.122720.71152047.sthaug@nethelp.no> <20180316.124748.104098359.sthaug@nethelp.no> <21eca372-6fc0-6c86-4ca8-a398bfa37d92@yandex.ru> <20180316.144734.78772139.sthaug@nethelp.no> From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Message-ID: <2b01893d-e2d0-b5a0-cfc4-1550f4d0c1da@yandex.ru> Date: Fri, 16 Mar 2018 17:47:28 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180316.144734.78772139.sthaug@nethelp.no> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eUVqF4WGzAsLGS7IChhUPLQIlU1JFsPTJ" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 14:49:00 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eUVqF4WGzAsLGS7IChhUPLQIlU1JFsPTJ Content-Type: multipart/mixed; boundary="7aznOmSKlcKOyNHAiCBQ5LiViBDq1I9YV"; protected-headers="v1" From: "Andrey V. Elsukov" To: sthaug@nethelp.no Cc: freebsd-net@freebsd.org, melifaro@ipfw.ru Message-ID: <2b01893d-e2d0-b5a0-cfc4-1550f4d0c1da@yandex.ru> Subject: Re: Does FreeBSD do proactive ARP refresh?,Re: Does FreeBSD do proactive ARP refresh? References: <20180316.122720.71152047.sthaug@nethelp.no> <20180316.124748.104098359.sthaug@nethelp.no> <21eca372-6fc0-6c86-4ca8-a398bfa37d92@yandex.ru> <20180316.144734.78772139.sthaug@nethelp.no> In-Reply-To: <20180316.144734.78772139.sthaug@nethelp.no> --7aznOmSKlcKOyNHAiCBQ5LiViBDq1I9YV Content-Type: multipart/mixed; boundary="------------6E23A3D56A03045BA3AFD375" Content-Language: en-US This is a multi-part message in MIME format. --------------6E23A3D56A03045BA3AFD375 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16.03.2018 16:47, sthaug@nethelp.no wrote: >> Can you test this patch? I did not tested it, but I think it should fi= x >> this issue. >=20 > Looks like this is a patch against HEAD. I don't have any boxes > running HEAD, but I can get one installed and test the patch this > weekend (unless you want to produce a patch against 11.1-STABLE). >=20 > I tried the patch manually applied on 11.1-STABLE, but got lots of > errors during kernel compilation (see the end of this message). I made the patch for stable/11, but I need some time to build kernel-toolchain, since compiler from head/ doesn't want to build stable/11 kernel :) --=20 WBR, Andrey V. Elsukov --------------6E23A3D56A03045BA3AFD375 Content-Type: text/x-patch; name="ethersubr11.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="ethersubr11.diff" Index: stable/11/sys/net/if_ethersubr.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- stable/11/sys/net/if_ethersubr.c (revision 331055) +++ stable/11/sys/net/if_ethersubr.c (working copy) @@ -292,7 +292,6 @@ ether_output(struct ifnet *ifp, struct mbuf *m, int hlen; /* link layer header length */ uint32_t pflags; struct llentry *lle =3D NULL; - struct rtentry *rt0 =3D NULL; int addref =3D 0; =20 phdr =3D NULL; @@ -320,9 +319,20 @@ ether_output(struct ifnet *ifp, struct mbuf *m, phdr =3D lle->r_linkdata; hlen =3D lle->r_hdrlen; pflags =3D lle->r_flags; + /* + * XXX: Check if we have feedback request + * from arptimer()/nd6_llinfo_timer(). + */ + if ((pflags & RLLE_VALID) && + lle->r_skip_req !=3D 0) { + LLE_REQ_LOCK(lle); + /* Notify that entry was used */ + lle->r_skip_req =3D 0; + lle->lle_hittime =3D time_uptime; + LLE_REQ_UNLOCK(lle); + } } } - rt0 =3D ro->ro_rt; } =20 #ifdef MAC --------------6E23A3D56A03045BA3AFD375-- --7aznOmSKlcKOyNHAiCBQ5LiViBDq1I9YV-- --eUVqF4WGzAsLGS7IChhUPLQIlU1JFsPTJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlqr2QAACgkQAcXqBBDI oXoRqAf/TqHNTheZDRgF1mtB3kPD70qjkpPteCf8BAIunPKwlRl/CqdT/ohizcye psI9gHcUbMCf0VppVHM8wiQDd+6axeAy5iBX5Dw3hzLcorp3duUHCCtHVS2cVjpJ /+M/CeGofKKLEcy+7PCvQUaeBXTOmdYqtqO6pfKCO/Ta64aAzAkwKQr+BS4MpDjE mtFRvDlb760cXlWqbHyj+purQFrYM5+ggQuy/o4jaI1L/4Rm52fEBL6cSPt9cios TQObPw/1rIEW8C25zavaOR331OK00Ok6JreGNQ0dohk7vYyDV0GrrSBWnarg2AAF AyDIRW2MDaj97X3K06NowTL/t+FhIg== =Q3fN -----END PGP SIGNATURE----- --eUVqF4WGzAsLGS7IChhUPLQIlU1JFsPTJ--