Date: Fri, 16 Mar 2018 17:47:28 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: sthaug@nethelp.no Cc: freebsd-net@freebsd.org, melifaro@ipfw.ru Subject: Re: Does FreeBSD do proactive ARP refresh?,Re: Does FreeBSD do proactive ARP refresh? Message-ID: <2b01893d-e2d0-b5a0-cfc4-1550f4d0c1da@yandex.ru> In-Reply-To: <20180316.144734.78772139.sthaug@nethelp.no> References: <20180316.122720.71152047.sthaug@nethelp.no> <20180316.124748.104098359.sthaug@nethelp.no> <21eca372-6fc0-6c86-4ca8-a398bfa37d92@yandex.ru> <20180316.144734.78772139.sthaug@nethelp.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--eUVqF4WGzAsLGS7IChhUPLQIlU1JFsPTJ
Content-Type: multipart/mixed; boundary="7aznOmSKlcKOyNHAiCBQ5LiViBDq1I9YV";
protected-headers="v1"
From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: sthaug@nethelp.no
Cc: freebsd-net@freebsd.org, melifaro@ipfw.ru
Message-ID: <2b01893d-e2d0-b5a0-cfc4-1550f4d0c1da@yandex.ru>
Subject: Re: Does FreeBSD do proactive ARP refresh?,Re: Does FreeBSD do
proactive ARP refresh?
References: <20180316.122720.71152047.sthaug@nethelp.no>
<20180316.124748.104098359.sthaug@nethelp.no>
<21eca372-6fc0-6c86-4ca8-a398bfa37d92@yandex.ru>
<20180316.144734.78772139.sthaug@nethelp.no>
In-Reply-To: <20180316.144734.78772139.sthaug@nethelp.no>
--7aznOmSKlcKOyNHAiCBQ5LiViBDq1I9YV
Content-Type: multipart/mixed;
boundary="------------6E23A3D56A03045BA3AFD375"
Content-Language: en-US
This is a multi-part message in MIME format.
--------------6E23A3D56A03045BA3AFD375
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
On 16.03.2018 16:47, sthaug@nethelp.no wrote:
>> Can you test this patch? I did not tested it, but I think it should fi=
x
>> this issue.
>=20
> Looks like this is a patch against HEAD. I don't have any boxes
> running HEAD, but I can get one installed and test the patch this
> weekend (unless you want to produce a patch against 11.1-STABLE).
>=20
> I tried the patch manually applied on 11.1-STABLE, but got lots of
> errors during kernel compilation (see the end of this message).
I made the patch for stable/11, but I need some time to build
kernel-toolchain, since compiler from head/ doesn't want to build
stable/11 kernel :)
--=20
WBR, Andrey V. Elsukov
--------------6E23A3D56A03045BA3AFD375
Content-Type: text/x-patch;
name="ethersubr11.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="ethersubr11.diff"
Index: stable/11/sys/net/if_ethersubr.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- stable/11/sys/net/if_ethersubr.c (revision 331055)
+++ stable/11/sys/net/if_ethersubr.c (working copy)
@@ -292,7 +292,6 @@ ether_output(struct ifnet *ifp, struct mbuf *m,
int hlen; /* link layer header length */
uint32_t pflags;
struct llentry *lle =3D NULL;
- struct rtentry *rt0 =3D NULL;
int addref =3D 0;
=20
phdr =3D NULL;
@@ -320,9 +319,20 @@ ether_output(struct ifnet *ifp, struct mbuf *m,
phdr =3D lle->r_linkdata;
hlen =3D lle->r_hdrlen;
pflags =3D lle->r_flags;
+ /*
+ * XXX: Check if we have feedback request
+ * from arptimer()/nd6_llinfo_timer().
+ */
+ if ((pflags & RLLE_VALID) &&
+ lle->r_skip_req !=3D 0) {
+ LLE_REQ_LOCK(lle);
+ /* Notify that entry was used */
+ lle->r_skip_req =3D 0;
+ lle->lle_hittime =3D time_uptime;
+ LLE_REQ_UNLOCK(lle);
+ }
}
}
- rt0 =3D ro->ro_rt;
}
=20
#ifdef MAC
--------------6E23A3D56A03045BA3AFD375--
--7aznOmSKlcKOyNHAiCBQ5LiViBDq1I9YV--
--eUVqF4WGzAsLGS7IChhUPLQIlU1JFsPTJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlqr2QAACgkQAcXqBBDI
oXoRqAf/TqHNTheZDRgF1mtB3kPD70qjkpPteCf8BAIunPKwlRl/CqdT/ohizcye
psI9gHcUbMCf0VppVHM8wiQDd+6axeAy5iBX5Dw3hzLcorp3duUHCCtHVS2cVjpJ
/+M/CeGofKKLEcy+7PCvQUaeBXTOmdYqtqO6pfKCO/Ta64aAzAkwKQr+BS4MpDjE
mtFRvDlb760cXlWqbHyj+purQFrYM5+ggQuy/o4jaI1L/4Rm52fEBL6cSPt9cios
TQObPw/1rIEW8C25zavaOR331OK00Ok6JreGNQ0dohk7vYyDV0GrrSBWnarg2AAF
AyDIRW2MDaj97X3K06NowTL/t+FhIg==
=Q3fN
-----END PGP SIGNATURE-----
--eUVqF4WGzAsLGS7IChhUPLQIlU1JFsPTJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2b01893d-e2d0-b5a0-cfc4-1550f4d0c1da>