From owner-freebsd-arch@freebsd.org Wed Oct 21 23:14:33 2015 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD9A4A1B951 for ; Wed, 21 Oct 2015 23:14:33 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 97C4919D6 for ; Wed, 21 Oct 2015 23:14:33 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 946EDA1B94F; Wed, 21 Oct 2015 23:14:33 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A1E4A1B94D for ; Wed, 21 Oct 2015 23:14:33 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 50C1C19D3 for ; Wed, 21 Oct 2015 23:14:32 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pasz6 with SMTP id z6so67614875pas.2 for ; Wed, 21 Oct 2015 16:14:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=ANO41QZauPrc3mfqSinMBECaPImJXb8tmPq1nPjo93s=; b=X8ULcXMqLOFT5LUmOiRWtpTIYn8cuwwGqXUWLQf9RKrZlIgLESwwfFODr/LPlzrJQw XLfaRXzCHk7hKcJIMCwfrhVunMDpIVG8RsmBOKt7vg/AzLuu1fk8eOre72lUJ6bVJY66 NfJ1//bPjHrVtTuvlkOkqa2YnIL+61fgiMvHFwOQskbXVPOymZ/OEiuz6nS0h9jz2SVm fRMGkFuK3ulYTdwGR9LDqc0uZP8tWWN82lVnu3hgQ1D2k4jh47LtkderQ3oD7UlOpvSd UJFelpKXrKpjUhv+HGwZScLxotUrtFsc/FYH7fr09huGKIpXLsSVRVO09k412r6JSawX 53/A== X-Gm-Message-State: ALoCoQkLwayFb+HTMlxlB8E4xVPyRiK31qpYYOkyJmlo1H/hCtoV2Gizg5OpG/qg3E2bqF2PX6ln X-Received: by 10.68.227.227 with SMTP id sd3mr13627966pbc.116.1445469271671; Wed, 21 Oct 2015 16:14:31 -0700 (PDT) Received: from [100.127.128.44] ([69.53.245.4]) by smtp.gmail.com with ESMTPSA id ns1sm11019189pbc.67.2015.10.21.16.14.30 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 16:14:31 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r289710 - in head/sys/modules: i2c/iicbb uart Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_282D0F5B-E85D-4B56-8E6F-CCC73F5B3C80"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5.2 From: Warner Losh In-Reply-To: Date: Wed, 21 Oct 2015 17:14:28 -0600 Cc: "freebsd-arch@freebsd.org" Message-Id: <79E318B6-4556-4323-9D40-14269B470DA4@bsdimp.com> References: <201510211830.t9LIUgWt061526@repo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 23:14:33 -0000 --Apple-Mail=_282D0F5B-E85D-4B56-8E6F-CCC73F5B3C80 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 21, 2015, at 1:16 PM, Ed Maste wrote: >=20 > On 21 October 2015 at 14:30, Ed Maste wrote: >> Author: emaste >> Date: Wed Oct 21 18:30:42 2015 >> New Revision: 289710 >> URL: https://svnweb.freebsd.org/changeset/base/289710 >>=20 >> Log: >> Build ofw_bus_if.h for modules that need it on arm64 >=20 > Module Makefile build rules for ofw_bus_if.h are a bit of a mess; some > modules build it unconditionally while others build it only on certain > archs. There are a large number of different combinations of sparc64, > mips, powerpc, arm, and aarch64. This is true for a number of other > arch-specific module Makefile support. Should we have MK_* knobs to > control these cases -- e.g. MK_OFW (MK_FDT?) here? That would at least > move the arch-specific tests to a common location. How much of the swamp do you want to drain? None: Create MK_OFW (not MK_FDT: it already means something else). Add a few lines to src.opts.mk. Watch me complain :) A little: Add DEV_OFW to options. Add DEV_OFW to the relevant KERN_OPTS clauses in sys/conf/config.mk and then test for it like so in the = modules makefiles: .if (${KERN_OPTS:MDEV_OFW}) =E2=80=A6 .endif Maybe add it in config.mk if MK_FDT is defined, but I=E2=80=99d prefer = not That=E2=80=99s what we=E2=80=99re really testing for here: is this = kernel likely to have the OFW routines being called. A lot: rewrite config(8). I=E2=80=99m hoping you=E2=80=99ll pick =E2=80=9Ca little=E2=80=9D to not = make things worse. Warner --Apple-Mail=_282D0F5B-E85D-4B56-8E6F-CCC73F5B3C80 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWKBxVAAoJEGwc0Sh9sBEAZ5UQANDuxcf5AoPIciDP7hKJk4In RclltBr7lkydMzjIfJJpBhZ5OF4OYpK79EcsTeuuqs0iXZYUwG/VS4TW1wL1M4jk kKhgR566o/Uh8g54//GTf+vk3+pik/x5yfno9IyR+I5h68rtQWncKN9ABq5PITTM FQVpS7yUc3/Rc/DpJJzEeKawcap1yPBShHsKdNgSRJRaVL5P5f2G6lm/xi+OyPtR aL57u+Lzp6AYAgSEfo/cu0rVE0q+tOnDUmt7alum1cz/HRO09ZYmhSgf+3RGeGs5 QLFoyZABYX1QECl9P3wSVV9Pr7Z9nBog06CZLubG0S4aFLDXmsZzMgeVO1ccgczQ mwF2tybWH6+qqkaU2ERO3Pg12uDG3Sd1jaz5u8w2bFNJmepNhlsL9aVojegRrEy5 6SrgqR9npxRD1Ywha0QxWG6s0bnvwZ5nPL/NNlfvNYjDCwACvfJvp0lYAFpFiH9z vEu0obksO+jkIvBNsgaATgqhYNKgGcNnsvNTQRUh8Lty/cWcC/+gYMSr8a3bhhe7 0pocUIJPNLBD7rarPr0W/FsJQqLByGX2+Fo36nuGgFHjnvktjjOFsS1SZrgrHsFx A/pTYLm6JvHLU9NQn+o8wz5ETTpZArMQz5sK1GrSK2nVcdwklWf92CLgw/ukjmby yiv6/8pi1pLNGEaE+87d =uHEi -----END PGP SIGNATURE----- --Apple-Mail=_282D0F5B-E85D-4B56-8E6F-CCC73F5B3C80--