From owner-svn-src-stable-10@freebsd.org  Mon Oct  1 16:10:28 2018
Return-Path: <owner-svn-src-stable-10@freebsd.org>
Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3C33510C2AA8;
 Mon,  1 Oct 2018 16:10:28 +0000 (UTC)
 (envelope-from asomers@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E5C747E048;
 Mon,  1 Oct 2018 16:10:27 +0000 (UTC)
 (envelope-from asomers@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E0CCB2327F;
 Mon,  1 Oct 2018 16:10:27 +0000 (UTC)
 (envelope-from asomers@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w91GARSE014870;
 Mon, 1 Oct 2018 16:10:27 GMT (envelope-from asomers@FreeBSD.org)
Received: (from asomers@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w91GAR7k014869;
 Mon, 1 Oct 2018 16:10:27 GMT (envelope-from asomers@FreeBSD.org)
Message-Id: <201810011610.w91GAR7k014869@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: asomers set sender to
 asomers@FreeBSD.org using -f
From: Alan Somers <asomers@FreeBSD.org>
Date: Mon, 1 Oct 2018 16:10:27 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject: svn commit: r339061 - stable/10/usr.bin/tftp
X-SVN-Group: stable-10
X-SVN-Commit-Author: asomers
X-SVN-Commit-Paths: stable/10/usr.bin/tftp
X-SVN-Commit-Revision: 339061
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable-10@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for only the 10-stable src tree
 <svn-src-stable-10.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-10/>
List-Post: <mailto:svn-src-stable-10@freebsd.org>
List-Help: <mailto:svn-src-stable-10-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2018 16:10:28 -0000

Author: asomers
Date: Mon Oct  1 16:10:27 2018
New Revision: 339061
URL: https://svnweb.freebsd.org/changeset/base/339061

Log:
  MFC r337779:
  
  tftp: Close a resource leak when putting files
  
  Reported by:	Coverity
  CID:		1394842

Modified:
  stable/10/usr.bin/tftp/main.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.bin/tftp/main.c
==============================================================================
--- stable/10/usr.bin/tftp/main.c	Mon Oct  1 16:09:20 2018	(r339060)
+++ stable/10/usr.bin/tftp/main.c	Mon Oct  1 16:10:27 2018	(r339061)
@@ -475,6 +475,7 @@ put(int argc, char *argv[])
 			printf("putting %s to %s:%s [%s]\n",
 			    cp, hostname, targ, mode);
 		xmitfile(peer, port, fd, targ, mode);
+		close(fd);
 		return;
 	}
 				/* this assumes the target is a directory */