From owner-svn-ports-all@FreeBSD.ORG Wed May 29 17:49:02 2013 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B9B97F7F; Wed, 29 May 2013 17:49:02 +0000 (UTC) (envelope-from ehaupt@critical.ch) Received: from mx.critical.ch (mx.critical.ch [62.2.45.171]) by mx1.freebsd.org (Postfix) with ESMTP id 3759CC2D; Wed, 29 May 2013 17:49:01 +0000 (UTC) Received: from beaver.home.critical.ch (84-75-192-66.dclient.hispeed.ch [84.75.192.66]) (authenticated bits=0) by mx.critical.ch (8.14.5/8.14.5/critical-1.0) with ESMTP id r4THmloN067213; Wed, 29 May 2013 19:48:48 +0200 (CEST) (envelope-from ehaupt@critical.ch) Date: Wed, 29 May 2013 19:48:47 +0200 From: Emanuel Haupt To: Emanuel Haupt Subject: Re: svn commit: r319384 - head/mail/milter-callback Message-Id: <20130529194847.2738e8fc165db5f658a2d54e@critical.ch> In-Reply-To: <201305291735.r4THZowZ077077@svn.freebsd.org> References: <201305291735.r4THZowZ077077@svn.freebsd.org> X-Mailer: Sylpheed 3.3.0 (GTK+ 2.24.18; amd64-portbld-freebsd9.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 May 2013 17:49:02 -0000 Emanuel Haupt wrote: > Author: ehaupt > Date: Wed May 29 17:35:50 2013 > New Revision: 319384 > URL: http://svnweb.freebsd.org/changeset/ports/319384 > > Log: > Fix build on HEAD by setting USE_GCC=any which I believe is better > than marking it BROKEN if clang is detected. In order to do that > handle do-build target since the distribution Makefile includes > which does not handle USE_GCC=any well. Question about that: What about making this standard policy for ports that don't build with clang? There is for instance sysutils/lsof which blocks archivers/tardy in a CC=clang environment. How about setting all the ports that fail to build with clang to USE_GCC=any and then fix them on them gradually? Emanuel > > Modified: > head/mail/milter-callback/Makefile > > Modified: head/mail/milter-callback/Makefile > ============================================================================== > --- head/mail/milter-callback/Makefile Wed May 29 16:52:39 > 2013 (r319383) +++ head/mail/milter-callback/Makefile > Wed May 29 17:35:50 2013 (r319384) @@ -15,16 +15,27 @@ > LIB_DEPENDS+= spf2:${PORTSDIR}/mail/libs > USE_XZ= yes > USE_RC_SUBR= milter-callback > +USE_GCC= any > > SUB_FILES= pkg-message > MAN8= milter-callback.8 > > -MAKE_ENV+= WITH_SPF=yes > MAKE_JOBS_SAFE= yes > > -.if ${CC} == "clang" || ${CXX} == "clang++" > -BROKEN= does not build with clang, uses nested functions > -.endif > +SRC_FILES= cache.c commonprocs.c cpit.c dealwithmxes.c > detectlamespf. > + makedecision.c mcspf.c milter-callback.c pgupdate.c \ > + processdirectpart.c processmxpart.c pushhistory.c > sigusr1.c + > +CFLAGS+= -DFREEBSD -DHAVE_NS_TYPE -DWITH_SPF -I > ${LOCALBASE}/include \ > + -I${WRKSRC} -std=gnu99 > +LDFLAGS+= -lmilter -lthr -L${LOCALBASE}/lib -lspf2 > + > +do-build: > +.for f in ${SRC_FILES} > + ${CC} ${CFLAGS} -c ${WRKSRC}/${f} -o ${WRKSRC}/${f:C/\.c/.o/} > +.endfor > + ${CC} ${LDFLAGS} ${SRC_FILES:C/(.*)\.c/${WRKSRC}\/\1.o/} \ > + -o ${WRKSRC}/${PORTNAME} > > post-patch: > @${REINPLACE_CMD} -e "s|/usr/local|${PREFIX}|" \ >