From owner-cvs-all@FreeBSD.ORG Wed Aug 25 17:45:25 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B56CE16A50D; Wed, 25 Aug 2004 17:45:25 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id F183543D1F; Wed, 25 Aug 2004 17:45:19 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i7PHidqs001165; Wed, 25 Aug 2004 11:44:40 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 25 Aug 2004 11:45:02 -0600 (MDT) Message-Id: <20040825.114502.91312696.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <412BC4C5.3000708@root.org> References: <412B9629.3080108@root.org> <20040824213627.GA61527@dragon.nuxi.com> <412BC4C5.3000708@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: obrien@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c acpi_resource.c acpivar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2004 17:45:25 -0000 In message: <412BC4C5.3000708@root.org> Nate Lawson writes: : David O'Brien wrote: : > On Tue, Aug 24, 2004 at 12:25:29PM -0700, Nate Lawson wrote: : > : >>David O'Brien wrote: : >> : >>>On Mon, Aug 23, 2004 at 04:28:42PM +0000, Nate Lawson wrote: : >>> : >>> : >>>>njl 2004-08-23 16:28:42 UTC : >>>>FreeBSD src repository : >>>>Modified files: : >>>> sys/dev/acpica acpi.c acpi_resource.c acpivar.h : >>>>Log: : >>>>Rework sysresource management. Instead of having each sysresource object : >>> : >>>... : >>> : >>> : >>>>Tested by: Pawel Worach : >>>>Tested by: Radek Kozlowski : >>> : >>> : >>>Tested only on i386, right?? : >> : >>Still waiting for the amd64 laptop donation. ;-) In any case, I've : >>just committed a fix. The amd64,ia64 nexus hadn't been caught up with : >>i386 and the resource code depends on the new method. : > : > In the future, may I make a request that you post patches for large : > changes before committing them? Now that ACPI is a multi-platform thing : > that is very basic to booting, we have to be careful about changes to it. : : For large commits (i.e. mpsafe patch), I post patches and get testing. : For critical bugfixes like this, I get the reporter to test after I test : and then commit. With the minimum MFC period, I want to get critical : bugfixes into HEAD as soon as they are tested (to start the clock) and : plan to be responsive to any subsequent bug reports. But to introduce a guaranteed core dump on non-i386 architectures is not acceptible. By rushing things in, you have inconvenienced many users of these platforms (amd64 is getting quite popular), which reduces the developer's time for further FreeBSD work since they have to deal with the core dump, track it down, etc. ACPI is so central to the system that such breakages should be avoided to the greatest extent possible. Warner