From owner-freebsd-perl@FreeBSD.ORG Sun Jul 31 23:14:33 2011 Return-Path: Delivered-To: perl@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 79FB9106564A; Sun, 31 Jul 2011 23:14:33 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id DE6B314F1BC; Sun, 31 Jul 2011 23:14:32 +0000 (UTC) Message-ID: <4E35E1D8.90300@FreeBSD.org> Date: Sun, 31 Jul 2011 16:14:32 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:5.0) Gecko/20110723 Thunderbird/5.0 MIME-Version: 1.0 To: Sahil Tandon References: <201107312100.p6VL0Z0s033087@repoman.freebsd.org> <4E35C372.9030209@FreeBSD.org> <20110731230750.GC8462@magic.hamla.org> In-Reply-To: <20110731230750.GC8462@magic.hamla.org> X-Enigmail-Version: 1.2pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Sunpoet Po-Chuan Hsieh , perl@FreeBSD.org Subject: Re: Fwd: cvs commit: ports/databases/p5-DBIx-Custom Makefile X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 23:14:33 -0000 On 07/31/2011 16:07, Sahil Tandon wrote: > On Sun, 2011-07-31 at 14:04:50 -0700, Doug Barton wrote: > >> Fix the build with what seems to have been the intended change from >> 1.28 >> >> It seems that the intention was to make a new BUILD_DEPENDS with the >> same content as the existing RUN_DEPENDS, but one line was missed, >> causing neither to work. So instead, make BUILD_DEPENDS equal to the >> old RUN_DEPENDS, and use the := method to set RUN_DEPENDS, in part >> because it helps avoid this kind of error. > > Thanks for your help. Your fix catalyzed an update to a newer upstream > version & the removal of unrequired dependency. Glad to help. It wasn't clear from the diff which direction the change was intended to be (remove the dep, or an incomplete copy/paste) so I made the safest guess I could. Happy that it all worked out in the end though. Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/