Date: Thu, 19 Jul 2012 10:20:08 +0400 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: Doug Barton <dougb@dougbarton.us> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Alex Kozlov <spam@rm-rf.kiev.ua>, Niclas Zeising <zeising@freebsd.org> Subject: Re: svn commit: r301039 - head/archivers/zlib Message-ID: <5007A718.3020805@yandex.ru> In-Reply-To: <5005FDBD.5000407@dougbarton.us> References: <201207172057.q6HKvEJc094784@svn.freebsd.org> <5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org> <20120717230739.GA66332@ravenloft.kiev.ua> <5005F1E3.7080606@dougbarton.us> <20120717234412.GA69885@ravenloft.kiev.ua> <5005FDBD.5000407@dougbarton.us>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton wrote on 18.07.2012 04:05: > On 07/17/2012 04:44 PM, Alex Kozlov wrote: >> It works because sh assume EOF == EOL, it's would fall in more strict parser. > > My first question to zi was, "Are you seeing any specific problems > caused by this?" If you can answer that question with real, specific > information then we can talk about that. If your concern is that it > *might* cause unknown problems with some unknown thing at some unknown > time in the future then I restate my original thesis: We have bigger > things to worry about, and this change isn't worth the repo churn. > > Doug The most obvious "problem" is that it triggers portlint warning and portlint instructs committers to fix that. Period. I agree that this is rather rare, and I only got such distinfo's when editing them manually (when I didn't know about `make makesum'). If there is consensus that this problem is not a problem at all, portlint should be changed and all will be happy. -- Regards, Ruslan Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5007A718.3020805>