From owner-svn-ports-head@FreeBSD.ORG Thu Jul 19 06:22:28 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6F84D1065673; Thu, 19 Jul 2012 06:22:28 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward2h.mail.yandex.net (forward2h.mail.yandex.net [84.201.187.147]) by mx1.freebsd.org (Postfix) with ESMTP id 07C238FC08; Thu, 19 Jul 2012 06:22:28 +0000 (UTC) Received: from smtp2h.mail.yandex.net (smtp2h.mail.yandex.net [84.201.187.145]) by forward2h.mail.yandex.net (Yandex) with ESMTP id 07493702117; Thu, 19 Jul 2012 10:21:49 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1342678910; bh=LvPqK+o1fkc9b5bQSPPWzm7Cu3fVPHSFp9KU2z3QPjs=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=THJRu7tyQ8i0QBSxOBYyQA9MjtqdM+RS93dD8np9/i9+8fKFJxezLsSdxWCfdjO9x XDI34c8IGp28fXKGwXZ9lAzZ6Hi34GevRjwJl/af61oSrz2En8ocadvUPGjGmn6vqn IfoY7OUu6dkBZdsx9BLrAwkV1o8I/rUoNyFuWWEk= Received: from smtp2h.mail.yandex.net (localhost [127.0.0.1]) by smtp2h.mail.yandex.net (Yandex) with ESMTP id 569E5170014A; Thu, 19 Jul 2012 10:21:49 +0400 (MSK) Received: from unknown (unknown [213.27.65.65]) by smtp2h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id LmKWE5IL-LmKKg8fo; Thu, 19 Jul 2012 10:21:48 +0400 X-Yandex-Rcpt-Suid: dougb@dougbarton.us X-Yandex-Rcpt-Suid: spam@rm-rf.kiev.ua X-Yandex-Rcpt-Suid: zeising@freebsd.org X-Yandex-Rcpt-Suid: ports-committers@freebsd.org X-Yandex-Rcpt-Suid: svn-ports-all@freebsd.org X-Yandex-Rcpt-Suid: svn-ports-head@freebsd.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1342678909; bh=LvPqK+o1fkc9b5bQSPPWzm7Cu3fVPHSFp9KU2z3QPjs=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=nMDHbjBRIWMTWMJuJ8wUf/e9AyWf0jzzipODf/eWLB5x+bos7FKhvLAOB0vJYO+9n GX+HHPB80mjmQWPQxhmPtBxCJ1P9MlNFgT7Q0hb2qGCJUkeGD5wKzdQWCN4E8Ulrtn Dkqr9rv9LkH22wRfdDk18IuRkCXQ1p2BLnx77uMM= Message-ID: <5007A718.3020805@yandex.ru> Date: Thu, 19 Jul 2012 10:20:08 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120619 Thunderbird/13.0.1 MIME-Version: 1.0 To: Doug Barton References: <201207172057.q6HKvEJc094784@svn.freebsd.org> <5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org> <20120717230739.GA66332@ravenloft.kiev.ua> <5005F1E3.7080606@dougbarton.us> <20120717234412.GA69885@ravenloft.kiev.ua> <5005FDBD.5000407@dougbarton.us> In-Reply-To: <5005FDBD.5000407@dougbarton.us> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Alex Kozlov , Niclas Zeising Subject: Re: svn commit: r301039 - head/archivers/zlib X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2012 06:22:28 -0000 Doug Barton wrote on 18.07.2012 04:05: > On 07/17/2012 04:44 PM, Alex Kozlov wrote: >> It works because sh assume EOF == EOL, it's would fall in more strict parser. > > My first question to zi was, "Are you seeing any specific problems > caused by this?" If you can answer that question with real, specific > information then we can talk about that. If your concern is that it > *might* cause unknown problems with some unknown thing at some unknown > time in the future then I restate my original thesis: We have bigger > things to worry about, and this change isn't worth the repo churn. > > Doug The most obvious "problem" is that it triggers portlint warning and portlint instructs committers to fix that. Period. I agree that this is rather rare, and I only got such distinfo's when editing them manually (when I didn't know about `make makesum'). If there is consensus that this problem is not a problem at all, portlint should be changed and all will be happy. -- Regards, Ruslan Tinderboxing kills... the drives.