From owner-cvs-all Thu May 23 6:44:24 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by hub.freebsd.org (Postfix) with ESMTP id 89B4537B413 for ; Thu, 23 May 2002 06:43:53 -0700 (PDT) Received: (qmail 25104 invoked from network); 23 May 2002 13:43:52 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail15.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 23 May 2002 13:43:52 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4NDhpF04217; Thu, 23 May 2002 09:43:51 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020523171421.L12695-100000@gamplex.bde.org> Date: Thu, 23 May 2002 09:43:31 -0400 (EDT) From: John Baldwin To: Bruce Evans Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern kern Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23-May-2002 Bruce Evans wrote: > On Wed, 22 May 2002, John Baldwin wrote: > >> jhb 2002/05/22 13:32:39 PDT >> >> Modified files: >> sys/i386/include cpufunc.h >> sys/kern kern_mutex.c >> Log: >> Rename pause() to ia32_pause() so it doesn't conflict with the pause() >> function defined in . I didn't #ifdef _KERNEL it because the >> mutex implementation in libpthread will probably need this. > > This shoots the messenger. The main bug is gross namespace pollution in > : > > %%% >#ifndef _VGL_H_ >#define _VGL_H_ > >#include >#include >#include >#include > %%% > > is really a kernel-only header, but it sometimes gets > abused in userland. I think this shouldn't be supported. It contains > mostly very machine-dependent interfaces, so it should be used in at most > the implementation of libvgl. libvgl uses i386 interfaces unconditionally, > so it only works on i386's, but this limitation is not documented. > > Bruce Well, I can see libpthread wanting to use this type of stuff, but that will also be a special case and will hopefully not conflict. (libpthread is going to want its own lock implementations that don't have to enter the kernel.) I don't mind renaming ia32_pause() back to pause() if someone wants to clean up libvgl. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message