From owner-cvs-all Fri Dec 14 9: 6:50 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 9361637B41A; Fri, 14 Dec 2001 09:06:29 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fBEH6IW10221; Fri, 14 Dec 2001 19:06:18 +0200 (EET) (envelope-from ru) Date: Fri, 14 Dec 2001 19:06:17 +0200 From: Ruslan Ermilov To: Mark Murray Cc: Luigi Rizzo , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011214190617.A7887@sunbay.com> References: <20011214184532.A99179@sunbay.com> <200112141659.fBEGx9U02211@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112141659.fBEGx9U02211@grimreaper.grondar.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Dec 14, 2001 at 04:59:08PM +0000, Mark Murray wrote: > > Now everybody knows that you don't actually use -CURRENT. :-) > > In -CURRENT, main() doesn't require a prototype. > > Please back these out. > > This is incorrect. I'm doing a big WARNS=2 sweep in usr.bin, and > main _does_ need proper prototyping. > > This is not a proper prototype: > > int main(); > > This is ok: > > int main(int, char **); > > and so is this (yeah, yeah, I know it is complete function): > > int > main(int argc, char *argv[]) > { > : > } > > but NOT this > > int > main() > { > : > } > Mark, we are talking about the different thing here. Recall the breakage when -Wmissing-prototype was put to WARNS? The solution was added by David O'Brien in: contrib/gcc.295/c-decl.c,v 1.4. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message