Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Jan 2020 11:23:18 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   [Bug 242616] [NEW PORT] www/py-flask-babelex: Adds i18n/l10n support to Flask applications
Message-ID:  <bug-242616-21822-r0QDx3E1Fb@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-242616-21822@https.bugs.freebsd.org/bugzilla/>
References:  <bug-242616-21822@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242616

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[NEW PORT]                  |[NEW PORT]
                   |www/py-flask-babelex:       |www/py-flask-babelex: Adds
                   |i18n/l10n support to Flask  |i18n/l10n support to Flask
                   |applications with the help  |applications
                   |of the Babel library        |

--- Comment #3 from Kubilay Kocak <koobs@FreeBSD.org> ---
Review items (already fixed locally):

 - COMMENT should match setup.py:description (modulo portlint compliance)
 - setup.py:*_requires declares version requirements, match these as closel=
y as
possible, given our *_DEPENDS syntax:

    install_requires=3D[
        'Flask',
        'Babel>=3D1.0',
        'speaklater>=3D1.2',
        'Jinja2>=3D2.5'
    ],

 - Port Makefile calls pytest but doesn't TEST_DEPEND on pytest
 - Doesn't appear project requires pytest (calls `python tests.py` [1])
 - Add comments to patches wherever possible, ideally including upstream
issue/PR/commit urls where applicable

[1] Makefile: @cd tests; python tests.py

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242616-21822-r0QDx3E1Fb>