From owner-freebsd-bugs@FreeBSD.ORG Fri Sep 6 23:00:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A5408FC8 for ; Fri, 6 Sep 2013 23:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 854612094 for ; Fri, 6 Sep 2013 23:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r86N000K015742 for ; Fri, 6 Sep 2013 23:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r86N00PF015701; Fri, 6 Sep 2013 23:00:00 GMT (envelope-from gnats) Resent-Date: Fri, 6 Sep 2013 23:00:00 GMT Resent-Message-Id: <201309062300.r86N00PF015701@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Fabian Keil Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E95BDF0D for ; Fri, 6 Sep 2013 22:57:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D86D42006 for ; Fri, 6 Sep 2013 22:57:15 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r86MvEl9033756 for ; Fri, 6 Sep 2013 22:57:14 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r86MvEDE033751; Fri, 6 Sep 2013 22:57:14 GMT (envelope-from nobody) Message-Id: <201309062257.r86MvEDE033751@oldred.freebsd.org> Date: Fri, 6 Sep 2013 22:57:14 GMT From: Fabian Keil To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/181900: [patch] Line breaks missing in geli's kern.geom.confxml entries X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 23:00:00 -0000 >Number: 181900 >Category: kern >Synopsis: [patch] Line breaks missing in geli's kern.geom.confxml entries >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Sep 06 23:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Fabian Keil >Release: HEAD >Organization: >Environment: FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #597 r255153+2c13cb0: Fri Sep 6 13:19:19 CEST 2013 fk@r500.local:/usr/obj/usr/src/sys/ZOEY amd64 >Description: The attached patch adds two missing line breaks for geli's kern.geom.confxml entries. >How-To-Repeat: Attach geli provider, execute sysctl kern.geom.confxml, note missing line breaks for KeysTotal and KeysAllocated. >Fix: Patch attached with submission follows: >From 1cf8de8c8b7d0c5b50f681bc8600d06cf57ac24e Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Wed, 4 Sep 2013 15:48:28 +0200 Subject: [PATCH] Add missing line breaks in geli's kern.geom.confxml entries --- sys/geom/eli/g_eli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/geom/eli/g_eli.c b/sys/geom/eli/g_eli.c index d6dcb4f..fc43372 100644 --- a/sys/geom/eli/g_eli.c +++ b/sys/geom/eli/g_eli.c @@ -1172,9 +1172,9 @@ g_eli_dumpconf(struct sbuf *sb, const char *indent, struct g_geom *gp, if (pp != NULL || cp != NULL) return; /* Nothing here. */ - sbuf_printf(sb, "%s%ju", indent, + sbuf_printf(sb, "%s%ju\n", indent, (uintmax_t)sc->sc_ekeys_total); - sbuf_printf(sb, "%s%ju", indent, + sbuf_printf(sb, "%s%ju\n", indent, (uintmax_t)sc->sc_ekeys_allocated); sbuf_printf(sb, "%s", indent); if (sc->sc_flags == 0) -- 1.8.2.2 >Release-Note: >Audit-Trail: >Unformatted: