From owner-freebsd-ports@FreeBSD.ORG Tue Jun 17 19:45:08 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 119EAF0C; Tue, 17 Jun 2014 19:45:08 +0000 (UTC) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.infracaninophile.co.uk", Issuer "ca.infracaninophile.co.uk" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 934AF25D4; Tue, 17 Jun 2014 19:45:07 +0000 (UTC) Received: from seedling.local (seedling.black-earth.co.uk [81.2.117.99]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.8/8.14.8) with ESMTP id s5HJj1uq017978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 17 Jun 2014 20:45:02 +0100 (BST) (envelope-from matthew@FreeBSD.org) Authentication-Results: lucid-nonsense.infracaninophile.co.uk; dmarc=none header.from=FreeBSD.org DKIM-Filter: OpenDKIM Filter v2.8.3 smtp.infracaninophile.co.uk s5HJj1uq017978 Authentication-Results: smtp.infracaninophile.co.uk/s5HJj1uq017978; dkim=none reason="no signature"; dkim-adsp=none X-Authentication-Warning: lucid-nonsense.infracaninophile.co.uk: Host seedling.black-earth.co.uk [81.2.117.99] claimed to be seedling.local Message-ID: <53A09AB4.2080607@FreeBSD.org> Date: Tue, 17 Jun 2014 20:44:52 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kurt Jaeger Subject: Re: ports/189880: port pgpool-II out of date. References: <201405170220.s4H2K0G0085365@freefall.freebsd.org> <538D0AAE.7090800@sorbs.net> <20140615111101.GM2341@home.opsec.eu> <539DA4F3.2060004@sorbs.net> <20140615142903.GQ2341@home.opsec.eu> <539DB9DD.3050603@FreeBSD.org> <20140617190940.GI9253@f10.opsec.eu> In-Reply-To: <20140617190940.GI9253@f10.opsec.eu> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oAJt628l0hb0On6gCh0BgsGEkXOWalsAJ" X-Virus-Scanned: clamav-milter 0.98.3 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lucid-nonsense.infracaninophile.co.uk Cc: michelle@sorbs.net, freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2014 19:45:08 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oAJt628l0hb0On6gCh0BgsGEkXOWalsAJ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 17/06/2014 20:09, Kurt Jaeger wrote: > Hi! >=20 > matthew@ wrote: >=20 >> There's a number of things wrong with this port, some inherited from t= he >> pgpool-II port you copied, and some where you're using outmoded constr= ucts. > [...] >> - Use options helpers rather than if $(PORT_OPTIONS:MFoo). Eg. >> instead of >> >> .if ${PORT_OPTIONS:MSSL} >> USE_OPENSSL=3D yes >> CONFIGURE_ARGS+=3D--with-openssl >> .endif >> >> use: >> >> SSL_CONFIGURE_WITH=3D openssl >> SSL_USE=3D OPENSSL=3DYES >> >> and similarly for the PAM option. >=20 > I tried this for PAM: >=20 > PAM_CONFIGURE_WITH+=3D pam > PAM_USE=3D PAM=3Dyes >=20 > and config.log contains=20 >=20 > #define USE_PAM 1 >=20 > even if the PAM option is not selected. You don't need +=3D there -- just plain =3D That should have resulted in configure being called with the argument --with-pam or --without-pam according to the option setting. One of those config.foo files it generates should have the command line that was used. There are a number of variations on the CONFIGURE options helpers -- read the comments in /usr/ports/Mk/bsd.options.mk for the gory details. > This leads to the compile failing for pool_hba.c with some pam-related = error, > see >=20 > http://people.freebsd.org/~pi/misc/pgpool-pam-error.txt >=20 > The other method worked. Do you have any idea why that happens ? Looks like it isn't calling configure with quite the right commandline. >> - The port cannot be staged as a non-root user. This is due to th= e >> way the contrib Makefiles are written -- although elsewhere it >> uses standard autoconf stuff, which pretty much just works for >> staging purposes. >=20 > I'm unsure what you mean with "the contrib Makefiles" ? >=20 > You refer to the >=20 > cd ${WRKSRC}/sql/${f} && ${GMAKE} \ > STAGEDIR=3D${STAGEDIR} \ > PREFIX=3D${PREFIX} \ > ${INSTALL_TARGET} >=20 > construct in target post-install ? Yes -- that's what I mean. If you try running 'make stage' as a non-root user, you'll see where it tries to run 'install -o root ...' (which doesn't work). Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. PGP: http://www.infracaninophile.co.uk/pgpkey --oAJt628l0hb0On6gCh0BgsGEkXOWalsAJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQJ8BAEBCgBmBQJToJq9XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NTNBNjhCOTEzQTRFNkNGM0UxRTEzMjZC QjIzQUY1MThFMUE0MDEzAAoJELsjr1GOGkAT9skP/j2KIdUChBhEPU6jVlT6yRdl tNUlse5bhBcUgDi7euD2YyP62qpzhIKDZqjCv9jRUVZDv1ZkVVZqmXmlwdXbD0m6 UmBLi0AlBXPjUghO+JoiIc3+XNOU7clp4zaSjPapnVNa4KlsMPegzr4TJ46hIyyh SfuZNPgHnS7Pa++vDWKcQZaN/bWa65B97WcMFtpFRnP80EMTvmgcxNX+LtW0iMAn OQu2lO+tDfI/hYVpuvVcSoA/0C8+6mUK/mkscZlXDBk4V3El5cN8kjCMMgxZHATH E1EvJi3h9rbABwKUn0t5PS3xbhCbDkRA5m6pfCmR1zM7LQQhaWqS87qWe8G7/qaZ ARzAMKdnE8CDzZq9LqJGJB7Lo8kN/T1/dH+h0MykcrGsTSHEYSX8xxhwOUQn2Vxd T917iw5pHK7bG3SQ+h1eU5ws9JVZj7DMtIFQbgogJ3o1CZzJjNOwlLpCt+Y+jqdc 8N0Koyr78qc2Mq70YGPt9rKkLm6wtu4snAskbnBIb0O+0FrK4PLUGtzCPLTwv93P 0ED3aa//8DT/DMPcR/DT9aSI4X7iza/3Zl1GVQRa010VBhw6pAYqip+A5pa/Mbok O1uRh+xLJibHQmRSoIhlrvcOi3wmu/+5mY8RriWzxEL8QEiIfQy4gskc+kfmvRMW a3I8yqQ3d6JbFB9VWYK5 =nPl6 -----END PGP SIGNATURE----- --oAJt628l0hb0On6gCh0BgsGEkXOWalsAJ--