From owner-svn-src-all@FreeBSD.ORG Thu Jan 7 11:29:36 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B00861065670; Thu, 7 Jan 2010 11:29:36 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 889A58FC12; Thu, 7 Jan 2010 11:29:36 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 1232E46B2E; Thu, 7 Jan 2010 06:29:36 -0500 (EST) Date: Thu, 7 Jan 2010 11:29:35 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Luigi Rizzo In-Reply-To: <20100104190024.GA47532@onelab2.iet.unipi.it> Message-ID: References: <201001041825.o04IPcXb043347@svn.freebsd.org> <20100104190024.GA47532@onelab2.iet.unipi.it> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Michael Tuexen Subject: Re: moving sctp to a separate directory ? (Re: svn commit: r201523 - head/sys/netinet) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 11:29:36 -0000 On Mon, 4 Jan 2010, Luigi Rizzo wrote: > taking a random commit to this tree -- would you guys consider moving the > sctp sources to its own directory, e.g. netinet/sctp/ or something that > suits better ? > > It would help to browse through the directory: > > NAME FILES LINES > > netinet/ 156 153k > sctp* 36 66k > tcp* 24 16k > ipfw/ 9 9k > > > I understand that some of the headers should remain in netinet/ but surely > the code is not bound to a specific place... Keep in mind that every file rename invalidates outstanding patch sets against those files maintained in our own branches, and at external vendors. I think we should be cautious about gratuitous renaming, as it increases the work factor both inside and outside the project significantly for relatively little gain. Especially when the files already have a quite consistent naming scheme that makes it easy to know which files belong to which component -- tcp_*, sctp_*, udp_*, etc. Robert N M Watson Computer Laboratory University of Cambridge > > cheers > luigi > > On Mon, Jan 04, 2010 at 06:25:38PM +0000, Michael Tuexen wrote: >> Author: tuexen >> Date: Mon Jan 4 18:25:38 2010 >> New Revision: 201523 >> URL: http://svn.freebsd.org/changeset/base/201523 >> >> Log: >> Correct usage of parenthesis. >> >> PR: kern/142066 >> Approved by: rrs (mentor) >> Obtained from: Henning Petersen, Bruce Cran. >> MFC after: 2 weeks >> >> Modified: >> head/sys/netinet/sctp_pcb.c >> >> Modified: head/sys/netinet/sctp_pcb.c >> ============================================================================== >> --- head/sys/netinet/sctp_pcb.c Mon Jan 4 18:21:27 2010 (r201522) >> +++ head/sys/netinet/sctp_pcb.c Mon Jan 4 18:25:38 2010 (r201523) >> @@ -5528,7 +5528,7 @@ sctp_pcb_init() >> >> /* Init the TIMEWAIT list */ >> for (i = 0; i < SCTP_STACK_VTAG_HASH_SIZE; i++) { >> - LIST_INIT(&SCTP_BASE_INFO(vtag_timewait[i])); >> + LIST_INIT(&SCTP_BASE_INFO(vtag_timewait)[i]); >> } >> >> #if defined(SCTP_USE_THREAD_BASED_ITERATOR) >> @@ -6385,7 +6385,7 @@ sctp_is_vtag_good(struct sctp_inpcb *inp >> } >> skip_vtag_check: >> >> - chain = &SCTP_BASE_INFO(vtag_timewait[(tag % SCTP_STACK_VTAG_HASH_SIZE))]; >> + chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)]; >> /* Now what about timed wait ? */ >> if (!LIST_EMPTY(chain)) { >> /* >