From owner-svn-src-all@FreeBSD.ORG  Fri Nov 21 16:14:33 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C8A27295;
 Fri, 21 Nov 2014 16:14:33 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B5219617;
 Fri, 21 Nov 2014 16:14:33 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id sALGEXZf089167;
 Fri, 21 Nov 2014 16:14:33 GMT (envelope-from trasz@FreeBSD.org)
Received: (from trasz@localhost)
 by svn.freebsd.org (8.14.9/8.14.9/Submit) id sALGEXUb089166;
 Fri, 21 Nov 2014 16:14:33 GMT (envelope-from trasz@FreeBSD.org)
Message-Id: <201411211614.sALGEXUb089166@svn.freebsd.org>
X-Authentication-Warning: svn.freebsd.org: trasz set sender to
 trasz@FreeBSD.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
Date: Fri, 21 Nov 2014 16:14:33 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r274797 - head/usr.sbin/ctld
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2014 16:14:33 -0000

Author: trasz
Date: Fri Nov 21 16:14:32 2014
New Revision: 274797
URL: https://svnweb.freebsd.org/changeset/base/274797

Log:
  Fix error handling.
  
  MFC after:	1 month
  Coverity CID:	1249768
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/usr.sbin/ctld/isns.c

Modified: head/usr.sbin/ctld/isns.c
==============================================================================
--- head/usr.sbin/ctld/isns.c	Fri Nov 21 15:49:41 2014	(r274796)
+++ head/usr.sbin/ctld/isns.c	Fri Nov 21 16:14:32 2014	(r274797)
@@ -63,7 +63,7 @@ isns_req_alloc(void)
 	req->ir_buflen = sizeof(struct isns_hdr);
 	req->ir_usedlen = 0;
 	req->ir_buf = calloc(req->ir_buflen, 1);
-	if (req == NULL) {
+	if (req->ir_buf == NULL) {
 		free(req);
 		log_err(1, "calloc");
 		return (NULL);