From owner-freebsd-stable@freebsd.org Thu Aug 17 10:16:30 2017 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85468DD916F; Thu, 17 Aug 2017 10:16:30 +0000 (UTC) (envelope-from chris@chrullrich.net) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0080.outbound.protection.outlook.com [104.47.0.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B8C336ADF4; Thu, 17 Aug 2017 10:16:28 +0000 (UTC) (envelope-from chris@chrullrich.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gloomberg.onmicrosoft.com; s=selector1-chrullrich-net; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Bqr8Gre7/jYITb/ji6nf8cIov0D4uaUpwZPgQw5/ihk=; b=DoKveyWmOKsXu7V6FdNVjeGdNdlVJfNnnyP3sBg9u2WIMqIGKiQFJJoOtFVLabqeLnBxtTHwbYBArIDtL/0TqxopsO+kSL4dibHf6cLsPfcpxrylicrNGPD27jJVOG9K1m6xFbdkCPublaFNv0a4uJniHXW7te8Ttmh9viTrg34= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=chris@chrullrich.net; Received: from [192.168.92.135] (217.31.70.82) by AM4PR10MB0226.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:200:2b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1341.21; Thu, 17 Aug 2017 10:16:25 +0000 Subject: Re: svn commit: r322609 - in stable/11: contrib/netbsd-tests/usr.bin/grep usr.bin/grep To: Kyle Evans References: <201708170426.v7H4Q4SL015844@repo.freebsd.org> From: Christian Ullrich Cc: svn-src-stable@freebsd.org, freebsd-stable@freebsd.org Message-ID: <0cf58b0e-51cd-27f9-1ce5-87ee0e8df207@chrullrich.net> Date: Thu, 17 Aug 2017 12:16:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <201708170426.v7H4Q4SL015844@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [217.31.70.82] X-ClientProxiedBy: AM5PR0402CA0002.eurprd04.prod.outlook.com (2603:10a6:203:90::12) To AM4PR10MB0226.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:200:2b::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9bbb8bea-4254-48e1-6606-08d4e559042e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM4PR10MB0226; X-Microsoft-Exchange-Diagnostics: 1; AM4PR10MB0226; 3:lZ87KY55gQImtmR/67Cv8uFjNKtwG1HPiBnoEbPElLAWlBI5QLFvid3Yl2XV8E8+oXnD7Qz46qJ0Ygpi4kc36FGt85/R39fOcWbXuu/HMcLPRLjApJdVN4h/hRXLxHFnuXYhGBpNW1td4tsTGHLC8h857ZDv0NPbTVAMQOju/cBNVndiPGZGK2PrmnR+LzVLMfUZ5iQpvLwlxkdBMI3s+6AsMtVk4s2+z7GpMWTGAy9/xcGqleHgXoABZP1EgsxX; 25:RAioTfq+LrmIMhTJ41G5j3+YBhD23TemjvKqSzymIam+ZgPqBB2qnFYcgis9ABQV1Gzt3yRpxzMkQky4a3TSDIcA3uGWhZ3CdNNfqP1Ykh9tpx5yPRkSW8bkaO5DSXaY5WnFrzwkICjye7ZyFBF/d61PdAZoi6ZcQsiYyvEOL/sBEgrHik781mB3/UxS5auMmFW+BtQrjFBAc7WRMyB5xmdvW1bIdCqYFfJCbQfFsXuTV/hWrk8qa33FJ9pLkjSA0N3ZiaPzj6EyAXEserkONysciQvic2lXIgZoEH+0pt7l34PNsb+ijpkXmilBjr6MyMFTCspKHOh6A9p+JeRlYQ==; 31:yU9BidF5liOzMclt3MTzCcWvM1D1TQjA8j2Ln83544gBq8qGhS5I8my1MTS1AtzBkhK1oJxO72RQ4m6SLPbJK9p/SVKRf065ZgETR7YuK4n3tGGzRUzcPPKjVCBU4yFdt1BCVRj+4yehaadpgOgDhGKYr7oVOIKacTmJZ0ol8aR2xev+cAnYTAXtPXMlmjtroMdDbDAvmILC4+FZTZOhoBm1rqoSpvwR2YngXQig0l0= X-MS-TrafficTypeDiagnostic: AM4PR10MB0226: X-Microsoft-Exchange-Diagnostics: 1; AM4PR10MB0226; 20:c1R9jQfUAciyjbvmqtIVPjIuYailMeW/ZzsV5lEkn8+iTZBKA9oszB3+fMvU+dtxgt9Ko9rJw38oLjEz887B1lOWOmpdqdQg8Q8qeOUnOr6M3HnAmM7rGQ/Kpd8sxandtKF75sErTzO/vEVp9Yg5mn3IG3bP7dkjIUq61/ATV+zoDqr+rfAq+W+zLpIkok/t9tkjlRJbR8sOvCL0foSq/q7Qec8L1vHv2GAeth9Oy9gRHnqqF1tM+fUxpVQvYmPd5TuQZ7LwozhDp7ksZKHQV5dPoZ879NUX8xCgy8ryz7cNhYrqNo6/MCA/Oc8HCQ6rHwORjF4SAnSbAKAYtD+cQL/EB9lh60kF0HVtjxe3J2i8sfTZFG8GuQxQ00Yyw4299doc3DCJd5Je43IDuJF+C8i188tAPKrnyM4RrS2Kj4roYBMNKgX7R2ilPwOIwyMNn4+J6OIJNeKcMhBJzbizeSJDa1kGoZjgP65kzXzUlAqBrRT5rDf/CQM3qvemv3Qk; 4:1coQ0M3BBQq+oSS5QiZO0X+lU0mHHHmPMLDtfabVvzWVoYqKfYSDe0UW8N66HaJwTqyxBfZOuspNmU6GmcDL7L6FWo4fYjdX8sLEbz4t0h8S4f5NBSeTYKefT3t6QegvUDD1+1a4vyvaXkysvgEgSpVOurXieDZKSt5VkkiHMk7bimUXXUwpvSBkvc3U6hdudYxNo6brWCH0M96H8JVI6apgozXOOYIfjHNmP3mA3TYmRXzX14olUuEgB5QaYJCQ3G3V/ruDdiktp0VpTsTkQbQRyWSWdRxRJhW0v9DZgx4= X-Exchange-Antispam-Report-Test: UriScan:(56005881305849); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(2016111802025)(20161123558100)(20161123560025)(6072148)(6043046)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR10MB0226; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR10MB0226; X-Forefront-PRVS: 0402872DA1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(6049001)(39830400002)(189002)(199003)(24454002)(65806001)(4326008)(305945005)(65956001)(66066001)(2906002)(50466002)(3260700006)(33646002)(6916009)(6666003)(6246003)(110136004)(7736002)(966005)(478600001)(6306002)(5660300001)(65826007)(2950100002)(8676002)(6116002)(25786009)(81156014)(3846002)(81166006)(83506001)(117156002)(450100002)(23676002)(50986999)(97736004)(76176999)(54356999)(6486002)(77096006)(101416001)(86362001)(53936002)(64126003)(31686004)(106356001)(105586002)(47776003)(4001350100001)(36756003)(68736007)(230700001)(189998001)(42186005)(229853002)(7350300001)(31696002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR10MB0226; H:[192.168.92.135]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:0; LANG:en; Received-SPF: None (protection.outlook.com: chrullrich.net does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjEwTUIwMjI2OzIzOkpIMUlXNFJUa1B2ZVJ3dUJOdFpIWDJDR3B4?= =?utf-8?B?ci9NbGxkYytQNWpKalFqMDV3SGVvMVk0WG1OanZ3alE0emhac2V4OFJFVTBo?= =?utf-8?B?VW44OUpGNXZOSmpYSlBTWmQzUG81UklFOGY1SUpHckIydnB5NUZUMFZPaGZh?= =?utf-8?B?Tms5ZU91eDBhdEpJYkRqSDIxUHZrVCtYRm5lWkl5NUVDbmsvdGZWOHZ6anYx?= =?utf-8?B?Z1FZUUNVMEU2SnRDWmRNcmR1aVQyZUVFbWF4UTQwb1VpZHJzbVNiN2p0VFRi?= =?utf-8?B?WWh3eWJnQUZFbVhyR3AzcU1aZG4rWHQrQ0NnVVVtNkNyU1AvTVFSTitHbDFz?= =?utf-8?B?ODFWNUtUZW03OVBCVmJIL1lmRHdHZ200UHhIclM2UjJtTnBqOTJiN1NPMDJF?= =?utf-8?B?dWdhWDNjaFdRcGdTTGZhcTVUY0IybUQrVHZObHNTcERXSWJjcDhwenRQd0hE?= =?utf-8?B?YWRIRnBwcllRTTh3dWdnN2lGV1lNNjhEQlFPbGM3TFRZUUZZZVhKK1UrcXFI?= =?utf-8?B?dXkwWVA3c0ozWW5JMWdOcEY1YkFHcC9kbGoxOFRVck45cEpzYUlldXl0MEJh?= =?utf-8?B?NkZrb29aMFNzSDlHK0hJK3Vzam0yZVhBMFQxTDZxdStERDhoaGtzN2ExNG9o?= =?utf-8?B?ZHc5SnR1MUVzVzVOaWwvUDNmaXgrN01TeVZpeTVrb1FxcDhMVFlDaFRqdGlR?= =?utf-8?B?N29oR094Vkx0UFpCSHRBZ2QzdExnS0NSS1R4QzE2dU5BbWZVaGVxZit1R29Q?= =?utf-8?B?K1NrZTdNbW5wVC9ZamdHUHg0TFBQWkNiTmx5MTB0VGwwbmRtYlB6UVNsMjND?= =?utf-8?B?OHczL09QajdNdjNBcS83TlN1a2NFd0k4c3JFQXRWZDJPQS83WG9tL1dleS84?= =?utf-8?B?d1FDVUttQTFzd3Z6TGVOUEtpTjg0RzFZdVhrNkNmK20rcXdkMW5sTEJJMEk2?= =?utf-8?B?UVBDZitQb1NWdzU1N1E2Y21qSlFkdEpRUWNHRlM0ajZLNEdTMi9lU3k0ZTF0?= =?utf-8?B?bmJkd3c5cUxmY1gxKy9SYUdMM2xNN2llcExYRHdRbGtPSjRHOXh0d3g2SFZj?= =?utf-8?B?aXY4UW5iTHUyTUlBZi9mejJJTVFMaE9OZ0ZhN0tsQkhkMEsvcjFpeHFlWkNs?= =?utf-8?B?M1pGdXVLT01kUHA1NVlnU1F5VE9iMGFSeityK0lSSllrd3l4R1ljMS9pVEdK?= =?utf-8?B?eHB4eklMeks2Nkk2QzJ1emdjeTRmYmlJMkdXRC9rL3NNUlYrQUlIRWVqbTFY?= =?utf-8?B?S3J0WEMvMHIya2JhL2xCem56T1ErR0NtcnN4RWRzNGVBRjZ3QkdiR0s4c2p4?= =?utf-8?B?aCsram9mT2pXdXBaMm5QV3pocE40ZVdOL24vN2MxNW1ab2dGUVFXdFNWeXhY?= =?utf-8?B?R0hLN0VGY0lZYW5vcUpuRE1yT3FZTmt2THBlcmF1T0R5MHNRcUQ1eUpQUHhn?= =?utf-8?B?Q25IL1FzMWFSYndlRDZWVkVkUlIxV1BmYjF1VVZxcXBNc0JnTEFjKzArRDJI?= =?utf-8?B?SzV1WG1ST0dXa1FzUFZvNlUrOTNWUXkxQVllc0RVSjBMUEJWVkNvb3h0Y21C?= =?utf-8?B?UDJSYVJMTU5sWGQvYVMrUUJOcU41NHc3dnZWLzBoLzlZQzFYaEZaaFBmR09E?= =?utf-8?B?N3JIYlJkQ3M2N0ZWdWxmRFo4V21OK0MwN1M4OThodGplOXlyVGJoVWFWdVUv?= =?utf-8?B?ZERKSVErR3ZoS2Q4YStjOEpIYWRVNTFXVWhtWGVPVzFIUUJHbHdzcXM2KzFz?= =?utf-8?B?bWtTMytTbldYUTVRRHNKVVJOM2paYlE3OU9TRHBWbWZ1c3NmNmFPdS9ER00v?= =?utf-8?B?MWhnS2tDQjBzc3lHM1pFc1VUamEzd0hUbFpRaW81dEV1Q3VjdmFqN052QXdx?= =?utf-8?B?YkJsT0tCZHB5bkJkc3JWTllXbHRaSjJjWHI5ZHIrS0FwZ0Z3L2N6ajJBUHY0?= =?utf-8?Q?AZPfVoquims6O2Edlc+/eJDs2GJ0Bw=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM4PR10MB0226; 6:LZ+3Nf2tBtX2eUqCI6uocTUJSFLwgZmyu8g6I7iJH46V5eJKF9CIC5JND1bIbvqA+Ktizt9bjSvrU0MLUU93kWcIRa3ckrz5K3LckN+HoUjTtluWoAVG6T6dqZselaoUxlX7ZtmdzZdCBx5Rb17AVvyGHIq38IK1sBteI0uFWWfi9PiBpdYTsx2q3H7E6HUpV8H8Md4cRXvuU93V92yuvx+/YZsQ6JJPHju8PZ3rqHi3IpmiBgGSF70uQXyH6Z/bXOwHAcJB+qovnNnvgxF6WgZk3pgmarVe2WyowcNDYKLJxERaMStjAjJnGqrFoQAvJH71AJPvTQd20m2E/USz+A==; 5:LTRhX3B30yHA88aFMdEmCbcwI6Y8PdyhZwLBYc2q7+M6eTlQND/QuGfQq6eKtFo1OXlYPqTGZoOZkHoQHoEOeRJ9nyVrTgwbPykFdARL1rnkCHBNOyVzH5EUwXeT83u1YyoN3ixwEaTSs+/tsmgopQ==; 24:hBe+aolnfSt2lh3kVhLXCsrogqv0vnflzEtRnOyJ3GviHKi4EjePr5dlkCw9ayREQWvHkRn2IBPUcJcS7UzDO6O3apnX6OSmSar6fvCumtc=; 7:s7urLIEUQZgwqc1EmWw0DbRBdzm5Fv23cJoymgOKz3P3aE6Uo+lkphntAwUIxDLSvTgJQD9xZeakDwoqOyt2m4aYwYlrylu2Bt1DQhWQOdHhcDOanyf+RxLU1AwKRUw5D2/Q72DkesCQNSYQLvmB1eYey+x/VMLuvVQJNXsFvGCfhc+73PyF+Mg75fdNHdx/XSAa5JrvvtbdAbhhlz5lfxiKKIzJQ77gj9vnamJly3s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: chrullrich.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2017 10:16:25.0144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR10MB0226 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Aug 2017 10:16:30 -0000 * Kyle Evans wrote: > Author: kevans > Date: Thu Aug 17 04:26:04 2017 > New Revision: 322609 > URL: https://svnweb.freebsd.org/changeset/base/322609 > > Log: > MFC r318571: bsdgrep: emit more than MAX_LINE_MATCHES per line > Modified: stable/11/usr.bin/grep/util.c > ============================================================================== > --- stable/11/usr.bin/grep/util.c Thu Aug 17 04:18:31 2017 (r322608) > +++ stable/11/usr.bin/grep/util.c Thu Aug 17 04:26:04 2017 (r322609) > @@ -356,11 +366,11 @@ procline(struct parsec *pc) > { > regmatch_t pmatch, lastmatch, chkmatch; > wchar_t wbegin, wend; > - size_t st = 0, nst = 0; > + size_t st, nst; > unsigned int i; > int c = 0, r = 0, lastmatches = 0, leflags = eflags; > size_t startm = 0, matchidx; > - int retry; > + unsigned int retry; /usr/src/usr.bin/grep/util.c:453:26: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] pmatch.rm_so + 1 < retry)) ~~~~~~~~~~~~~~~~ ^ ~~~~~ Why would that fail after MFC? Doesn't head use -Werror too? # uname -a FreeBSD infra-poudriere 11.1-PRERELEASE FreeBSD 11.1-PRERELEASE #0 r[unhelpful]: Thu Jul 13 15:30:11 CEST 2017 toor@infra11build:/usr/obj/usr/src/sys/LOCAL amd64 ]# cc --version FreeBSD clang version 4.0.0 (tags/RELEASE_400/final 297347) (based on LLVM 4.0.0) Target: x86_64-unknown-freebsd11.1 Thread model: posix InstalledDir: /usr/bin -- Christian