From owner-cvs-all Sat Jan 19 8: 9: 3 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 2D2AD37B404; Sat, 19 Jan 2002 08:08:58 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 254395326; Sat, 19 Jan 2002 17:08:57 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c References: <200201190901.g0J91H641020@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: 19 Jan 2002 17:08:55 +0100 In-Reply-To: <200201190901.g0J91H641020@freefall.freebsd.org> Message-ID: Lines: 15 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrey A. Chernov" writes: > Log: > Add PAM_CRED_ERR as valid failure case It's not. Only pam_setcred() is allowed to return PAM_CRED_ERR. None of your patches to pam_opie, pam_unix or ftpd were reviewed by anyone with in-depth knowledge of PAM. I'd like you to back them all out and submit them to markm and myself for review, along with a *detailed* explanation of what you think is wrong and why you think your patch is correct. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message