From owner-freebsd-testing@FreeBSD.ORG Sun Mar 2 23:00:28 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5B774C8B for ; Sun, 2 Mar 2014 23:00:28 +0000 (UTC) Received: from mail-qa0-f66.google.com (mail-qa0-f66.google.com [209.85.216.66]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 149D212ED for ; Sun, 2 Mar 2014 23:00:27 +0000 (UTC) Received: by mail-qa0-f66.google.com with SMTP id m5so1018054qaj.1 for ; Sun, 02 Mar 2014 15:00:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=sR0rzFdYw7Jl1Jrd7kaSnzVRMs5HUv+JaAFl1kyO+Os=; b=Ryi8tmDIoWVJeFXRDemV92IPEAS2Zu8PP4x+JpgJOxXxgrpBJnzWUfUq8w6whpihfv bEL7CWGyyhHQlfUH8hlRmIC4QumPtUBO20ApargnddFWzXH7ZbAb8mpSH7HX9gTl7Koq nYk9OzU/HhL1lBg0SQjBQF9AvboJqIJ1RnFn8kbBh9wWo/bkt+C+pcj9LP/uEf/Hw3iB qzYNYgNW4kxTHpAEBvyH+vFhG6rjJ12lF4JDWM+LnX+DOdhSIceUkRyPER8X7Ulb2Wk6 jAsY9u7pUjVDZDR7gKfwDfHecM1FIMIKW/KoCJ7iVDrzTVSHqPUCbBx7dgCubpkmJ/NM lyuw== X-Gm-Message-State: ALoCoQluH2geRweQ/qV6bpepnQsgQqYAAroicisOqCdhQoM6UAx7tvBSaBDvWVf7RypXK5M2WuHz X-Received: by 10.140.40.5 with SMTP id w5mr18679727qgw.65.1393801221165; Sun, 02 Mar 2014 15:00:21 -0800 (PST) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.102 with HTTP; Sun, 2 Mar 2014 15:00:01 -0800 (PST) X-Originating-IP: [108.176.158.82] In-Reply-To: <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> From: Julio Merino Date: Sun, 2 Mar 2014 18:00:01 -0500 X-Google-Sender-Auth: A58BaNNo39RNqvGh4MiXPDXvXyA Message-ID: Subject: Re: [PATCH] Integrate pjdfstest into the build To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-testing@freebsd.org" , Pawel Jakub Dawidek X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Mar 2014 23:00:28 -0000 On Sun, Mar 2, 2014 at 5:54 PM, Garrett Cooper wrote: >> * The test files should move from tools/regression/pjdfstest/ into the >> new location under tests/sys/ and be renamed to follow the conventions >> under src/test (e.g. xx.t -> xx_test). > > Please talk to Pawel about this. These tests have been developed and are = maintained (to some degree) outside FreeBSD: https://github.com/pjd/pjdfste= st . I'd rather treat this as an integration of the 3rd party package, not = a refactor. If you want me to install the tests like _test though, I'd be m= ore than happy to do that. Ah great; that's what I suspected given the mentions of other OSes in the c= ode! Then I believe this should really live under contrib/pjdfstest. Any reason it's not there? If it's external, then yes, we should keep the layout of the upstream sources without performing any renames (unless Pawel wants to do them). Thanks