Date: Sun, 27 Jun 2004 18:00:23 GMT From: Lewis Thompson <purple@lewiz.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68215: NEW PORT: multimedia/freevo, an open-source home theatre PC platform Message-ID: <200406271800.i5RI0NF0073985@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/68215; it has been noted by GNATS.
From: Lewis Thompson <purple@lewiz.net>
To: Volker Stolz <vs@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/68215: NEW PORT: multimedia/freevo, an open-source home theatre PC platform
Date: Sun, 27 Jun 2004 18:54:08 +0100
--O3RTKUHj+75w1tg5
Content-Type: multipart/mixed; boundary="WYTEVAkct0FjGQmd"
Content-Disposition: inline
--WYTEVAkct0FjGQmd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Jun 25, 2004 at 01:27:21PM +0200, Volker Stolz wrote:
> ...
> # Should these have exists() ?
> # Without them freevo setup still detects applications but ports doesn't
> # create the full dependency list.
> .if defined(WITH_XINE)
> RUN_DEPENDS+=3Dxine:${PORTSDIR}/multimedia/xine
> .endif
>=20
> This is not good. You should always record the exact dependencies.
> Please *also* use exists() ("... exists(foo) || defined(WITH_FOO)...". =
=20
> Provide some sanity-checks,
> in case WITH_foo and autodetection conflict. Or maybe there's something =
=20
> like configure's
> --disable-foo, which will prevent feature-detection?
Hi,
Thanks for taking the time to have a look. Here is a patch for various
files (I'm hoping it will work!). This fixes the problem you mentioned,
as well as getting rid of WITH_SENSIBLE (instead I changed certain
defaults to YES) and adds a few more things to the sample config file.
Sorry this took so long -- I've been busy packing. Thanks again,
-lewiz.
--=20
I was so much older then, I'm younger than that now. --Bob Dylan, 1964.
------------------------------------------------------------------------
-| msn:purple@lewiz.net | jabber:lewiz@jabber.org | url:www.lewiz.org |-
--WYTEVAkct0FjGQmd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=freevo-patch
Content-Transfer-Encoding: quoted-printable
diff -ruN freevo.orig/Makefile freevo/Makefile
--- freevo.orig/Makefile Fri Jun 25 12:32:10 2004
+++ freevo/Makefile Sun Jun 27 18:50:03 2004
@@ -6,10 +6,6 @@
#
# You can set the following options when compiling Freevo:
#
-# WITH_SENSIBLE
-# default: NO
-# Build Freevo with a sensible set of applications.
-#
# WITH_MPLAYER
# default: YES
# Enable mplayer video playback support.
@@ -31,19 +27,19 @@
# Enable zsnes game support.
#
# WITH_XMLTV
-# default: autodetect
+# default: YES
# Enable TV guide listings support.
#
# WITH_CDPARANOIA
-# default: autodetect
+# default: YES
# Enable cdparanoia audio extraction support.
#
# WITH_LAME
-# default: autodetect
+# default: YES
# Enable lame MP3 encoding support.
#
# WITH_OGG
-# default: autodetect
+# default: YES
# Enable Ogg Vorbis encoding support.
#
# WITH_FLAC
@@ -51,7 +47,7 @@
# Enable FLAC encoding support.
#
# WITH_LIRC
-# default: autodetect
+# default: YES
# Enable lirc remote control support.
#
=20
@@ -75,32 +71,45 @@
${PYTHON_SITELIBDIR}/mmpython/__init__.py:${PORTSDIR}/multimedia/mmpytho=
n \
${PYTHON_SITELIBDIR}/_xmlplus/__init__.py:${PORTSDIR}/textproc/py-xml \
=20
-.if !defined(WITHOUT_MPLAYER)
-WITH_MPLAYER=3D yes
-.endif
+USE_PYTHON=3D yes
+USE_PYDISTUTILS=3D yes
+USE_REINPLACE=3D yes
+PKGINSTALL=3D pkg-install
=20
-.if !defined(WITHOUT_XINE)
-WITH_XINE=3D yes
-.endif
+DOCSDIR=3D ${PREFIX}/share/doc/${DISTNAME}
+CONF=3D ${PREFIX}/etc/${PORTNAME}
+
+.include <bsd.port.pre.mk>
+
+###
+# AUTODETECTION
+###
=20
-.if defined(WITH_SENSIBLE)
-WITH_XINE=3D YES
+.if exists(${X11BASE}/bin/xmame) && !defined(WITHOUT_MAME)
WITH_MAME=3D YES
+.endif
+
+.if exists(${X11BASE}/bin/snes9x) && !defined(WITHOUT_SNES9X)
WITH_SNES9X=3D YES
-WITH_XMLTV=3D YES
-WITH_CDPARANOIA=3DYES
-WITH_OGG=3D YES
-WITH_LIRC=3D YES
.endif
=20
-.if defined(WITH_MPLAYER)
+.if exists(${X11BASE}/bin/zsnes) && !defined(WITHOUT_ZSNES)
+WITH_ZSNES=3D YES
+.endif
+
+.if exists(${LOCALBASE}/bin/flac) && !defined(WITHOUT_FLAC)
+WITH_FLAC=3D YES
+.endif
+
+###
+# CONFIGURE RUN_DEPENDS
+###
+
+.if !defined(WITHOUT_MPLAYER)
RUN_DEPENDS+=3D mplayer:${PORTSDIR}/multimedia/mplayer
.endif
=20
-# Should these have exists() ?
-# Without them freevo setup still detects applications but ports doesn't
-# create the full dependency list.
-.if defined(WITH_XINE)
+.if !defined(WITHOUT_XINE)
RUN_DEPENDS+=3D xine:${PORTSDIR}/multimedia/xine
.endif
=20
@@ -116,19 +125,19 @@
RUN_DEPENDS+=3D zsnes:${PORTSDIR}/emulators/zsnes
.endif
=20
-.if defined(WITH_XMLTV)
+.if !defined(WITHOUT_XMLTV)
RUN_DEPENDS+=3D tv_cat:${PORTSDIR}/textproc/p5-xmltv
.endif
=20
-.if defined(WITH_CDPARANOIA)
+.if !defined(WITHOUT_CDPARANOIA)
RUN_DEPENDS+=3D cdparanoia:${PORTSDIR}/audio/cdparanoia
.endif
=20
-.if defined(WITH_LAME)
+.if !defined(WITHOUT_LAME)
RUN_DEPENDS+=3D lame:${PORTSDIR}/audio/lame
.endif
=20
-.if defined(WITH_OGG)
+.if !defined(WITHOUT_OGG)
RUN_DEPENDS+=3D oggenc:${PORTSDIR}/audio/vorbis-tools
.endif
=20
@@ -136,18 +145,10 @@
RUN_DEPENDS+=3D flac:${PORTSDIR}/audio/flac
.endif
=20
-.if defined(WITH_LIRC)
+.if !defined(WITHOUT_LIRC)
RUN_DEPENDS+=3D ${PYTHON_SITELIBDIR}/pylircmodule.so:${PORTSDIR}/comms/py-=
lirc
.endif
=20
-USE_PYTHON=3D yes
-USE_PYDISTUTILS=3D yes
-USE_REINPLACE=3D yes
-PKGINSTALL=3D pkg-install
-
-DOCSDIR=3D ${PREFIX}/share/doc/${DISTNAME}
-CONF=3D ${PREFIX}/etc/${PORTNAME}
-
post-patch:
@${REINPLACE_CMD} -e 's|/etc/freevo|${PREFIX}/etc/freevo|' ${WRKSRC}/free=
vo_config.py
@${REINPLACE_CMD} -e 's|/etc/freevo|${PREFIX}/etc/freevo|' ${WRKSRC}/loca=
l_conf.py.example
@@ -162,4 +163,4 @@
${INSTALL_SCRIPT} ${WRKDIR}/freevo.sh.sample ${PREFIX}/etc/rc.d/
@${SED} 's|%%PREFIX%%|${PREFIX}|' ${PKGMESSAGE}
=20
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
diff -ruN freevo.orig/files/patch-local_conf.py freevo/files/patch-local_co=
nf.py
--- freevo.orig/files/patch-local_conf.py Fri Jun 25 12:32:10 2004
+++ freevo/files/patch-local_conf.py Sun Jun 27 18:20:14 2004
@@ -1,6 +1,22 @@
---- local_conf.py.example.old Thu Jun 10 15:21:50 2004
-+++ local_conf.py.example Thu Jun 10 15:22:39 2004
-@@ -126,6 +126,7 @@
+--- local_conf.py.example.old Sun Jun 27 18:00:29 2004
++++ local_conf.py.example Sun Jun 27 18:15:20 2004
+@@ -92,6 +92,15 @@
+ # ENABLE_SHUTDOWN_SYS =3D 0
+=20
+ #
++# FreeBSD shutdown-specific options.
++#
++# SHUTDOWN_SYS_CMD =3D '/sbin/shutdown -p now'
++# RESTART_SYS_CMD =3D '/sbin/shutdown -r now'
++#
++# You might consider installing sudo and having:
++# SHUTDOWN_SYS_CMD =3D '/usr/local/bin/sudo /sbin/...'
++
++#
+ # You can add more keybindings by adding them to the correct hash.=20
+ # e.g. If you want to send 'contrast -100' to mplayer by pressing the '1'=
key,=20
+ # just add the following line:=20
+@@ -126,6 +135,7 @@
# Freevo can write to.
#
# OVERLAY_DIR =3D os.path.join(FREEVO_CACHEDIR, 'vfs')
@@ -8,7 +24,7 @@
=20
#
# Umask setting for all files.
-@@ -133,6 +134,7 @@
+@@ -133,6 +143,7 @@
# installation with different users, set this to 002
#
# UMASK =3D 022
@@ -16,3 +32,22 @@
=20
#
# Suffix for playlist files
+@@ -195,6 +206,18 @@
+ # Enable this for joystick support:
+ # plugin.activate('joy')
+=20
++#
++# Extra FreeBSD default plugins (all detailed on the Freevo Wiki's
++# PluginInfo page):
++plugin.activate('idlebar')
++#plugin.activate('idlebar.mail')
++plugin.activate('idlebar.tv')
++#plugin.activate('idlebar.weather', level=3D30, args=3D('CODE'))
++plugin.activate('idlebar.clock')
++plugin.activate('idlebar.cdstatus')
++plugin.activate('idlebar.holidays')
++plugin.activate('idlebar.sensors')
++
+ # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
+ # Freevo directory settings:
+ # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--WYTEVAkct0FjGQmd--
--O3RTKUHj+75w1tg5
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFA3wnAItq0KFQv7T8RApDHAKCktu4lEW4Q1WFthUnMYcnP1YNObgCfW2lF
fveNug0THF+rRB9JBuD5+NI=
=myQ0
-----END PGP SIGNATURE-----
--O3RTKUHj+75w1tg5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406271800.i5RI0NF0073985>