From owner-cvs-all Thu Sep 6 17:27:30 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 444C337B403; Thu, 6 Sep 2001 17:27:17 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id f870RDi26212; Fri, 7 Sep 2001 01:27:13 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id f870RAD48771; Fri, 7 Sep 2001 01:27:10 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200109070027.f870RAD48771@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Poul-Henning Kamp , "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Brian Somers Subject: Re: cvs commit: src/lib/libc/stdio fdopen.c fflush.c fopen.c fseek.c ftell.c fvwrite.c local.h refill.c stdio.c In-Reply-To: Message from Poul-Henning Kamp of "Mon, 03 Sep 2001 07:26:53 +0200." <20159.999494813@critter> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 07 Sep 2001 01:27:10 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > In message <200109021910.f82JACD82362@freefall.freebsd.org>, "Andrey A. Chernov > " writes: > >ache 2001/09/02 12:10:12 PDT > > > > Modified files: > > lib/libc/stdio fdopen.c fflush.c fopen.c fseek.c ftell.c > > fvwrite.c local.h refill.c stdio.c > > Log: > > Move all stdio internal flags processing and setting out of __sread(), > > __swrite() and __sseek() to higher level. According to funopen(3) they all > > are just wrappers to something like standard read(2), write(2) and > > lseek(2), i.e. must not touch stdio internals because they are replaceable > > with any other functions knows nothing about stdio internals. See example > > of funopen(3) usage in sendmail sources f.e. > > > > NOTE: this is original stdio bug, not result of my range checkin added. > > NOTE: You forgot to add "Reviewed by: xxx" > > Or do you seriously think that mucking about in STDIO doesn't need > a review ? In this case I think it does. This commit broke ppp. To reproduce the problem: $ ppp Working in interactive mode Using interface: tun1 ppp ON hak> set server 1234 hello ppp ON hak> ^Z [1]+ Stopped ppp $ bg [1]+ ppp & $ pppctl 1234 And it just hangs there. Can you please either fix this or back the change out Andrey ? > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message