From owner-cvs-all@FreeBSD.ORG  Thu Jan  8 08:07:53 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from green.bikeshed.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9EB5F16A4CE; Thu,  8 Jan 2004 08:07:53 -0800 (PST)
Received: from green.bikeshed.org (green@localhost [127.0.0.1])
	by green.bikeshed.org (8.12.10/8.12.9) with ESMTP id i08G7rnU011054;
	Thu, 8 Jan 2004 11:07:53 -0500 (EST)
	(envelope-from green@green.bikeshed.org)
Received: from localhost (green@localhost)i08G7q5U011051;
	Thu, 8 Jan 2004 11:07:52 -0500 (EST)
Message-Id: <200401081607.i08G7q5U011051@green.bikeshed.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Ruslan Ermilov <ru@FreeBSD.org>
In-Reply-To: Message from Ruslan Ermilov <ru@FreeBSD.org> 
	<20040108080514.GB27761@FreeBSD.org.ua> 
From: "Brian F. Feldman" <green@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 08 Jan 2004 11:07:52 -0500
Sender: green@green.bikeshed.org
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/mk bsd.obj.mk 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jan 2004 16:07:54 -0000

Ruslan Ermilov <ru@FreeBSD.org> wrote:
> On Wed, Jan 07, 2004 at 03:41:03PM -0500, Brian F. Feldman wrote:
> > Ruslan Ermilov <ru@FreeBSD.org> wrote:
> > > On Thu, Jan 01, 2004 at 09:05:48PM -0800, Brian Feldman wrote:
> > > > green       2004/01/01 21:05:48 PST
> > > > 
> > > >   FreeBSD src repository
> > > > 
> > > >   Modified files:
> > > >     share/mk             bsd.obj.mk 
> > > >   Log:
> > > >   Fix a very corner case when you want to make cleandir SUBDIRs which
> > > >   are built using a ${MAKE} that's not just "make".
> > > >   
> > > >   Test by:        make universe (followed by cleandirs)
> > > >   
> > > >   Revision  Changes    Path
> > > >   1.49      +2 -2      src/share/mk/bsd.obj.mk
> > > > 
> > > The old version used ${MAKE}, why this was a problem at all?
> > 
> > The ${MAKE} that it uses would be overridden by the default ${MAKE} value 
> > each time; this doesn't occur when dependencies are executed, though.
> > 
> Please explain in more detail.  With the below makefile,
> 
> : all:
> : 	@cd ${.CURDIR}; ${MAKE} print-make
> : 
> : print-make:
> : 	@echo ${MAKE}
> 
> running /usr/bin/make will rightfully print "/usr/bin/make".
> make(1)'s main() always sets MAKE to argv[0] as its first task.

Here is the difference in behavior:

{"/home/green/tmp/x"}$ make print-make all
make
make
{"/home/green/tmp/x"}$ make MAKE='/usr/bin/make -DNONDEF' print-make all
/usr/bin/make -DNONDEF
/usr/bin/make


-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\