Date: Tue, 4 Mar 2003 18:57:01 -0500 From: "Mike Edenfield" <kutulu@kutulu.org> To: "Poul-Henning Kamp" <phk@phk.freebsd.dk> Cc: <freebsd-hackers@FreeBSD.ORG> Subject: Re: D_KQFILTER & ltmdm. Message-ID: <015001c2e2a9$c0459050$29330f0a@lcapps.educate.com> References: <42651.1046817582@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
Sent: Tuesday, March 04, 2003 5:39 PM
Subject: Re: D_KQFILTER & ltmdm.
> >2) The patch, which I've included below, only works for -CURRENT with
> >rev1.170 of conf.h. I wasn't sure how to get the preprocessor to
> >differentiate between -CURRENT before and after this specific revision of
a
> >specific file. What is the correct way to do this? Or, alternatively,
> >should the patch simply assume FreeBSD 5 is the latest -CURRENT and not
> >worry about the imcompatibility w/ 5.0-RELEASE?
>
> I have bumped __FreeBSD_version so you can test for this.
Will do. Where do I look to find the version numbers?
> But your patch is wrong. Please format the initialization like
> you see in all the other device drivers:
>
> static struct cdevsw sio_cdevsw = {
> .d_maj = MAJOR_AUTO,
> .d_flags = D_TTY,
> .d_open = sioopen
> etc
> etc
Ok. I didn't choose that formatting, it was the existing ltmdm code. I
simply moved the lines around to match the correct order. But I will change
this before I submit a new patch.
Thanks!
--Mike
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?015001c2e2a9$c0459050$29330f0a>