From owner-freebsd-hackers Tue Mar 4 15:57: 7 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEC8A37B401 for ; Tue, 4 Mar 2003 15:57:05 -0800 (PST) Received: from c001.snv.cp.net (h005.c001.snv.cp.net [209.228.32.119]) by mx1.FreeBSD.org (Postfix) with SMTP id 0532A43FA3 for ; Tue, 4 Mar 2003 15:57:03 -0800 (PST) (envelope-from kutulu@kutulu.org) Received: (cpmta 8107 invoked from network); 4 Mar 2003 15:57:02 -0800 Received: from 64.212.128.3 (HELO kutulu) by smtp.register-admin.com (209.228.32.119) with SMTP; 4 Mar 2003 15:57:02 -0800 X-Sent: 4 Mar 2003 23:57:02 GMT Message-ID: <015001c2e2a9$c0459050$29330f0a@lcapps.educate.com> From: "Mike Edenfield" To: "Poul-Henning Kamp" Cc: References: <42651.1046817582@critter.freebsd.dk> Subject: Re: D_KQFILTER & ltmdm. Date: Tue, 4 Mar 2003 18:57:01 -0500 Organization: KutuluWare Software Services MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1106 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG From: "Poul-Henning Kamp" Sent: Tuesday, March 04, 2003 5:39 PM Subject: Re: D_KQFILTER & ltmdm. > >2) The patch, which I've included below, only works for -CURRENT with > >rev1.170 of conf.h. I wasn't sure how to get the preprocessor to > >differentiate between -CURRENT before and after this specific revision of a > >specific file. What is the correct way to do this? Or, alternatively, > >should the patch simply assume FreeBSD 5 is the latest -CURRENT and not > >worry about the imcompatibility w/ 5.0-RELEASE? > > I have bumped __FreeBSD_version so you can test for this. Will do. Where do I look to find the version numbers? > But your patch is wrong. Please format the initialization like > you see in all the other device drivers: > > static struct cdevsw sio_cdevsw = { > .d_maj = MAJOR_AUTO, > .d_flags = D_TTY, > .d_open = sioopen > etc > etc Ok. I didn't choose that formatting, it was the existing ltmdm code. I simply moved the lines around to match the correct order. But I will change this before I submit a new patch. Thanks! --Mike To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message