From nobody Fri Jul 10 14:58:34 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gxZhp3kJhz6lG5l for ; Fri, 10 Jul 2026 14:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gxZhp2zsMz3xWY for ; Fri, 10 Jul 2026 14:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783695514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oIId9tWBaBTh5jHnnZUfODbjEB3F7tlZA3UkqHyq2/k=; b=DomvT3ab1BRUcgroD/JH/+7XDejVeM20UuJzDX8nckKNhYB/iLRk/aC3e+5QPHLGexlbbm aieEQr6I4ugG5hcD25HIUDxC2+avnhRcvZmZSRYbp1+9ttYJxSEtUhoWz8JmIi3dTQXzbB s9dSB+0HciIzPI9iQz0BB5XHjq6VLDSt7BI4t3qYTcBk3rC9HKHKd4MJyTo+qHG0CSQdJ3 kLiXQyAwNVGqz2JVBodTyCxh5Q2m6HBbGw6tlE3iW4fFtiiHbytjp5I8rfoUvmVUT7VfaZ js7l2s4Bg8AkFLUU3ZgEp8dx9y5PhJSJFMVi+Ls5EToA+YZEi6uh/tSIW4hDQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783695514; a=rsa-sha256; cv=none; b=WjAQFCKu4blZVEyk1TuwIxRHqzQjAbS0oQ43YXKQ8XzxOEjpzWALFKhO3zUQGQlm+jdAYf YR8fS3PRg+BmsL+XPhDxOEtach3+zhkbovYLgBoEycOD1I4c2CmTuaChf+KfsD/jUrTCW6 szNLok/QZFezsNBY6Wn8iC1QbeVQr1u/p80rueiq/B/7PQ1DBpWNKp9fzA8LFstHhP2W8d NmQHhRWO6iih1EoAD3v/wndo/2lu1RInN5aNicJUiixf8r4MPjEhcPsy5f4jlCix+rvX+x Rele7Zrq5DScIuty2XQYx34lomPu6CSQQPBIMl5oaae/nJqMySfes1wnVDxvIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783695514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oIId9tWBaBTh5jHnnZUfODbjEB3F7tlZA3UkqHyq2/k=; b=AgHrYAf6sIfqPY8WOVmxV9mztrotNy1N5qFekwL/8CQqQazFTH6OvWnQgT5se1jzhlDwu/ isPEmLuLyyXlTJmscWe37w1HxXhp8qlEe/gB+lhhJh1hjdwerckGBg8SCRNd5EyNYqKqhj BkUKfmJmrFzHuMoh9korQai5ELC7jpEtVsYygC5a0KAfo/IvHWiIFPsVPe97ypWqVkwBYf vr0rfMt7rSvLg24h8JBQyFnB/Np4pOZwbGMnIHvKmloIGa4B33rysRAzESvXgXv+xQ7HH6 6/3eIFSFqGVG4JioauD2yRHQub1o+sb5c32rcOW4gRCEyF0mTPZ5VDbnXqI7BA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gxZhp1rQlz10SW for ; Fri, 10 Jul 2026 14:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31201 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 10 Jul 2026 14:58:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: c18512056301 - main - readelf: Add support for ELF package metadata note List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c18512056301fa97dd31c4cc9a78e18f1aa8b2d5 Auto-Submitted: auto-generated Date: Fri, 10 Jul 2026 14:58:34 +0000 Message-Id: <6a51089a.31201.763338f6@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=c18512056301fa97dd31c4cc9a78e18f1aa8b2d5 commit c18512056301fa97dd31c4cc9a78e18f1aa8b2d5 Author: Ed Maste AuthorDate: 2022-04-20 14:12:06 +0000 Commit: Ed Maste CommitDate: 2026-07-10 14:58:15 +0000 readelf: Add support for ELF package metadata note We don't use this note type today, but as a general purpose ELF diagnostic tool readelf(1) ought to decode it. References: https://fedoraproject.org/wiki/Changes/Package_information_on_ELF_objects https://systemd.io/ELF_PACKAGE_METADATA/ Reviewed by: fuz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D47524 --- contrib/elftoolchain/readelf/readelf.c | 38 +++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/contrib/elftoolchain/readelf/readelf.c b/contrib/elftoolchain/readelf/readelf.c index 43585459d82e..d49505756fef 100644 --- a/contrib/elftoolchain/readelf/readelf.c +++ b/contrib/elftoolchain/readelf/readelf.c @@ -47,6 +47,7 @@ #include #include #include +#include #include #include @@ -371,6 +372,7 @@ static int loc_at_comparator(const void *la1, const void *la2); static const char *mips_abi_fp(uint64_t fp); static const char *note_type(const char *note_name, unsigned int et, unsigned int nt); +static const char *note_type_fdo(unsigned int nt); static const char *note_type_freebsd(unsigned int nt); static const char *note_type_freebsd_core(unsigned int nt); static const char *note_type_go(unsigned int nt); @@ -1150,6 +1152,8 @@ note_type(const char *name, unsigned int et, unsigned int nt) return note_type_freebsd_core(nt); else return note_type_freebsd(nt); + else if (strcmp(name, "FDO") == 0 && et != ET_CORE) + return note_type_fdo(nt); else if (strcmp(name, "GNU") == 0 && et != ET_CORE) return note_type_gnu(nt); else if (strcmp(name, "Go") == 0 && et != ET_CORE) @@ -1163,6 +1167,15 @@ note_type(const char *name, unsigned int et, unsigned int nt) return note_type_unknown(nt); } +static const char * +note_type_fdo(unsigned int nt) +{ + switch (nt) { + case NT_FDO_PACKAGING_METADATA: return "NT_FDO_PACKAGING_METADATA"; + default: return (note_type_unknown(nt)); + } +} + static const char * note_type_freebsd(unsigned int nt) { @@ -3819,7 +3832,30 @@ dump_notes_data(struct readelf *re, const char *name, uint32_t type, } ubuf = (const uint32_t *)(const void *)buf; - if (strcmp(name, "FreeBSD") == 0) { + if (strcmp(name, "FDO") == 0) { + switch (type) { + case NT_FDO_PACKAGING_METADATA: + { + char *visbuf; + + if (sz > SIZE_MAX / 4 - 1) { + warnx("invalid note data"); + return; + } + /* Ignore trailing NULs. */ + while (sz > 0 && buf[sz - 1] == '\0') { + sz--; + } + if ((visbuf = malloc(sz * 4 + 1)) == NULL) { + err(1, "malloc"); + } + (void)strvisx(visbuf, buf, sz, VIS_CSTYLE); + printf(" Package metadata: %s\n", visbuf); + free(visbuf); + return; + } + } + } else if (strcmp(name, "FreeBSD") == 0) { switch (type) { case NT_FREEBSD_ABI_TAG: if (sz != 4)