From owner-svn-src-all@FreeBSD.ORG  Thu Jan 15 03:23:07 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A959D106564A;
	Thu, 15 Jan 2009 03:23:07 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 52A978FC13;
	Thu, 15 Jan 2009 03:23:07 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by pele.citylink.co.nz (Postfix) with ESMTP id 78EDFFEF2;
	Thu, 15 Jan 2009 16:23:06 +1300 (NZDT)
X-Virus-Scanned: Debian amavisd-new at citylink.co.nz
Received: from pele.citylink.co.nz ([127.0.0.1])
	by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id NpJ8tLC-Q+HZ; Thu, 15 Jan 2009 16:23:02 +1300 (NZDT)
Received: from citylink.fud.org.nz (unknown [202.8.44.45])
	by pele.citylink.co.nz (Postfix) with ESMTP;
	Thu, 15 Jan 2009 16:23:02 +1300 (NZDT)
Received: by citylink.fud.org.nz (Postfix, from userid 1001)
	id 169281142C; Thu, 15 Jan 2009 16:23:02 +1300 (NZDT)
Date: Wed, 14 Jan 2009 19:23:01 -0800
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Craig Rodrigues <rodrigc@FreeBSD.org>
Message-ID: <20090115032301.GA78451@citylink.fud.org.nz>
References: <200901150241.n0F2fQ7B060823@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200901150241.n0F2fQ7B060823@svn.freebsd.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r187260 - head/sys/conf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2009 03:23:08 -0000

On Thu, Jan 15, 2009 at 02:41:26AM +0000, Craig Rodrigues wrote:
> Author: rodrigc
> Date: Thu Jan 15 02:41:26 2009
> New Revision: 187260
> URL: http://svn.freebsd.org/changeset/base/187260
> 
> Log:
>   When building up the command-line for the DTrace ctfmerge and ctfconvert
>   utilities, add the ${DEBUG} variable from the kernel config.  Otherwise,
>   if we build a kernel with WITH_CTF=1 set, ctfmerge will not have
>   the -g flag set.  In this case, the cc has -g specified, so the
>   .o files will have debug information generated, but since ctfmerge
>   does not have -g set, it will strip out the ELF sections containing
>   the DWARF debugging info, leading to a kernel without debugging symbols.
>   
>   Reviewed by:	jb
> 
> Modified:
>   head/sys/conf/kern.pre.mk
> 
> Modified: head/sys/conf/kern.pre.mk
> ==============================================================================
> --- head/sys/conf/kern.pre.mk	Thu Jan 15 02:35:40 2009	(r187259)
> +++ head/sys/conf/kern.pre.mk	Thu Jan 15 02:41:26 2009	(r187260)
> @@ -129,7 +129,7 @@ NORMAL_M= ${AWK} -f $S/tools/makeobjops.
>  	  ${CC} -c ${CFLAGS} ${WERROR} ${PROF} ${.PREFIX}.c
>  
>  .if defined(CTFCONVERT)
> -NORMAL_CTFCONVERT= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET}
> +NORMAL_CTFCONVERT= ${CTFCONVERT} ${DEBUG} ${CTFFLAGS} ${.TARGET}

It seems this was also a few days ago fixed by
http://svn.freebsd.org/changeset/base/187103

One of which is now redundant?


Andrew