Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Sep 2013 03:18:18 GMT
From:      Jason Bacon <jwbacon@tds.net>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/182077: maintainer update: science/minc2
Message-ID:  <201309140318.r8E3IIic088737@oldred.freebsd.org>
Resent-Message-ID: <201309140320.r8E3K0U5059785@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         182077
>Category:       ports
>Synopsis:       maintainer update: science/minc2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 14 03:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Jason Bacon
>Release:        9.1-RELEASE
>Organization:
Acadix Consulting, LLC
>Environment:
FreeBSD portstest.jbacon.dyndns.org 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Fixes an incompatibility introduced by the upgrade to 2.2, which now used hdf5 1.8 instead of hdf5 1.6.  Also updated DEPENDS to ensure that users are made aware of the true problem when the wrong version of hdf5 is installed.

Note also that many other ports requiring hdf5 1.8 might accept an installed hdf5 1.6 as satisfying LIB_DEPENDS=hdf5, which may cause compile errors due to differences in the hdf5 API between 1.6 to 1.8.

I intend to notify the maintainers of the hdf5 ports and all ports that depend on them.

>How-To-Repeat:
Install science/hdf5, then try to build minc2 from source.

If science/hdf5-18 is installed, the minc2 build will succeed.
>Fix:
Patch attached.

Patch attached with submission follows:

diff -ruN --exclude=CVS /usr/ports/science/minc2/Makefile /usr/wip/science/minc2/Makefile
--- /usr/ports/science/minc2/Makefile	2013-08-22 18:55:13.000000000 -0500
+++ /usr/wip/science/minc2/Makefile	2013-09-13 21:58:13.000000000 -0500
@@ -12,7 +12,7 @@
 
 PORTNAME=	minc
 PORTVERSION=	2.2.00
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	science biology
 MASTER_SITES=	http://packages.bic.mni.mcgill.ca/tgz/
 
@@ -21,12 +21,22 @@
 
 LICENSE=	BSD
 
-LIB_DEPENDS=	netcdf.4:${PORTSDIR}/science/netcdf \
-		hdf5:${PORTSDIR}/science/hdf5
+LIB_DEPENDS=	netcdf.4:${PORTSDIR}/science/netcdf
+
+# The hdf5 API changed after version 1.6.
+# LIB_DEPENDS=hdf5 is satisfied by either science/hdf5 or science/hdf5-18,
+# which can cause build failures in ports requiring hdf5 1.8 if hdf5 1.6
+# is already installed.  Several ports that depend on hdf5 have this bug.
+# LIB_DEPENDS=hdf5.7 will break the port when a minor hdf5 ugrade occurs.
+# Below is a kludgey but reliable way to ensure that hdf5 > 1.6 is installed.
+# The pkgsrc >= syntax would be a nice addition for this, e.g.
+# LIB_DEPENDS=	hdf5>=1.8.0
+
+BUILD_DEPENDS=	${LOCALBASE}/bin/h5copy:${PORTSDIR}/science/hdf5-18
+RUN_DEPENDS=	${LOCALBASE}/bin/h5copy:${PORTSDIR}/science/hdf5-18
 
 USE_LDCONFIG=	yes
 USES=		cmake:outsource bison:build
-CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include -DH5_USE_16_API
 LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 CMAKE_ARGS=	-DMINC2_BUILD_SHARED_LIBS:BOOL=YES
 


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309140318.r8E3IIic088737>