From owner-cvs-all Thu May 23 7: 1:18 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id 5B05837B410 for ; Thu, 23 May 2002 07:01:03 -0700 (PDT) Received: (qmail 11658 invoked from network); 23 May 2002 14:01:01 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 23 May 2002 14:01:01 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4NE10F04275; Thu, 23 May 2002 10:01:00 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200205230817.g4N8HGQ52273@freefall.freebsd.org> Date: Thu, 23 May 2002 10:00:39 -0400 (EDT) From: John Baldwin To: SXren Schmidt Subject: RE: cvs commit: src/sys/dev/ata ata-disk.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23-May-2002 SXren Schmidt wrote: > sos 2002/05/23 01:17:16 PDT > > Modified files: > sys/dev/ata ata-disk.c > Log: > Dont panic if only one disk on a channel can do tagged queueing. > > MFC: asap BTW, a guy here at work has a panic with his Promise controller here at work. He is not using any type of RAID, but it dies with the following traceback: ad_service+0x36 ad_transfer() ata_start() ad_strategy() ar_rw() ar_promise_read_conf() ata_raiddisk_attach() ... ata_boot_attach() The line at ad_service+0x36 is: sys/dev/ata/ata-disk.c:678: int ad_service(struct ad_softc *adp, int change) { ... if (adp->device->unit == ATA_MASTER) { * if (adp->device->channel->devices & ATA_ATA_SLAVE && ((struct ad_softc *) (adp->device->channel-> device[ATA_DEV(ATA_SLAVE)].driver))->flags&AD_F_TAG_ENABLED) device = ATA_SLAVE; } The panic is a page fault null-pointer dereference. Since we looked at adp->device_unit ok w/o blowing up, my guess is that adp->device->channel is NULL. This is during bootup btw, and he's had this panic for several months now. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message