From nobody Wed Jul 8 18:09:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gwR2Y27fgz6kcpW for ; Wed, 08 Jul 2026 18:09:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gwR2X6fxDz4Cm6 for ; Wed, 08 Jul 2026 18:09:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783534196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z6jqpgynSnK1jlF6AGyjotVcH7lOGs45rnHmYHHYA0g=; b=vp92Lnh3jzB17DWnWVbt+S8lwwytQW9N4RpLbKLHLkOCObegJOB5/ncxYE8yNKOsQyTSjJ MLJC4sWoZH+AAhAMr5LOXMZOk8Icxewl0glNCurAOFQ04s8xhcL3R6nuSDGr8SjgIzLcbO SMIoaFkRn5UaoPOkd/hv6GDVBMf7e2ZysRv0XiSUpj1bcWP3QDsj9yi9MfpJCNAku5jnCm 0icEZA2fL8nkGYlgmnvU84AobK/oXyxFLNc3r40tQ5r0y7YrEtJ/Ix9rPe6xSkX8bPkbY/ lQsjSLA4d4V/ulA7rBIra52wAWnw+NsAMCwHZ9CmntTX1nCTgslduuy50aHxXw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783534196; a=rsa-sha256; cv=none; b=oAw3weD59JJMQP/MmuVFJ2hwCFwEcpt4vCR8HHRPp2IJIziyLoEcfzT9cstVODdSh3bO61 5bzQGcKFLR3TggYdbhfOUt0Li3yLmsrSfXX1B7p7Bj2AEmv9SnRNhWyEivz7oyUbfWE4PX xroOBX8AoxfJuYec7/cYHv/gzRurxP8r5gKDosndi09Ns9W3Fx9l0XPSGbGqnnPOvvB+cY i8DocvVAwD4bQdbw3da8cVll/gcopOS7ANE+FoGrJeFiQKy3MiAPpvBczFiAoU7KimGFKB oISuk38nCe0kwanMBdB1QBuuLdcnwap+tQAil5rL2gPWLSEz4x2oWxUs1ZH53g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783534196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z6jqpgynSnK1jlF6AGyjotVcH7lOGs45rnHmYHHYA0g=; b=dqaunpll0hqrxvFRMaK8UqbltCS1i4RlZhloh+a7SI+VtKJqJG5oUZU0KFVM0WMd1YQiSR lkBsIW9TLz6x3N/oBZ9EYUB6grccBseioipgtTmrLH43a6/mHnSgGBhhmvk1R2mhgP//RY 25//t3KZ4ESBuznNSmOszP4Ome/PH+K4zFHhtgjeyZb6/JEdK5ar9DjrhrBkxYvpZV1Huh ca4EX0sM61pMhoBS0mzRa26K5gRO72xlMHRvqDOr6zB4OiOikfH6gFtWIiTH0HfX43SBM4 DQVfzfys90zKzuIEOUKB8RQJeY1/hTjpsw2nKB0z/5fzPGsMYC0FKzq5t/gwSA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gwR2X59NNzZ5k for ; Wed, 08 Jul 2026 18:09:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38a66 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 08 Jul 2026 18:09:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Jane Smith From: Mark Johnston Subject: git: fae2b85dfee6 - stable/15 - librpcsec_gss: Fix an off-by-one in rpc_gss_get_principal_name() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: fae2b85dfee628637cd645ffa98d411e2ec0e420 Auto-Submitted: auto-generated Date: Wed, 08 Jul 2026 18:09:56 +0000 Message-Id: <6a4e9274.38a66.198e5196@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=fae2b85dfee628637cd645ffa98d411e2ec0e420 commit fae2b85dfee628637cd645ffa98d411e2ec0e420 Author: Jane Smith AuthorDate: 2026-06-22 21:40:53 +0000 Commit: Mark Johnston CommitDate: 2026-07-08 18:09:35 +0000 librpcsec_gss: Fix an off-by-one in rpc_gss_get_principal_name() Include an extra byte for the nul-terminator, otherwise we may end up with an out-of-bounds write. The corresponding bug in the kernel implementation was fixed by commit e3081f7e3e2d ("kgssapi(4): Fix string overrun in Kerberos principal construction"). Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D57738 (cherry picked from commit 635ad6f2ec97e9c6b1f15620cd5ee84eb632082f) --- lib/librpcsec_gss/svc_rpcsec_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librpcsec_gss/svc_rpcsec_gss.c b/lib/librpcsec_gss/svc_rpcsec_gss.c index 73b92371e6d0..a15542330697 100644 --- a/lib/librpcsec_gss/svc_rpcsec_gss.c +++ b/lib/librpcsec_gss/svc_rpcsec_gss.c @@ -247,7 +247,7 @@ rpc_gss_get_principal_name(rpc_gss_principal_t *principal, * Construct a gss_buffer containing the full name formatted * as "name/node@domain" where node and domain are optional. */ - namelen = strlen(name); + namelen = strlen(name) + 1; if (node) { namelen += strlen(node) + 1; }