From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jun 21 12:20:13 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 111F1106566B for ; Thu, 21 Jun 2012 12:20:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BBFE58FC08 for ; Thu, 21 Jun 2012 12:20:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5LCKCrF089710 for ; Thu, 21 Jun 2012 12:20:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5LCKC0J089709; Thu, 21 Jun 2012 12:20:12 GMT (envelope-from gnats) Date: Thu, 21 Jun 2012 12:20:12 GMT Message-Id: <201206211220.q5LCKC0J089709@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Cc: Subject: Re: ports/164177: audio/squeezeboxserver should require mysql 5.0 server rather than just mysql server X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: the_mix_room@hotmail.com List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2012 12:20:13 -0000 The following reply was made to PR ports/164177; it has been noted by GNATS. From: To: Cc: Subject: Re: ports/164177: audio/squeezeboxserver should require mysql 5.0 server rather than just mysql server Date: Thu, 21 Jun 2012 12:15:14 +0000 --_4281e75e-976c-4a2f-bdf1-085368573516_ Content-Type: multipart/alternative; boundary="_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_" --_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_ Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable I have patched the Makefile to make the necessary adjustments so that squee= zeboxserver can be installed and run. =20 The problem is that with the introduction of MySQL 5.5 some commands are no= longer available. They have been replaced by equivalents.=20 http://dev.mysql.com/doc/refman/5.5/en/server-options.html#option_mysqld_sk= ip-external-locking as an example.=20 The commands are taken from: http://permalink.gmane.org/gmane.music.equipme= nt.slimdevices.squeezecenter/26896 I believe applying the patch below is the simplest until upstream gets fixe= d. Would be good if this relatively simple patch could be committed.=20 --- Makefile 2012-06-21 14:08:40.000000000 +0200 +++ Makefile.new 2012-06-21 13:58:08.000000000 +0200 @@ -57=2C7 +57=2C6 @@ .endif =20 USE_MYSQL=3D server -WANT_MYSQL_VER=3D50 =20 .if ${PORT_OPTIONS:MAPE} RUN_DEPENDS+=3D mac:${PORTSDIR}/audio/mac @@ -173=2C6 +172=2C12 @@ -e 's|%%TMP_SLIMDIR%%|${TMP_SLIMDIR}|g' \ ${WRKSRC}/scanner.pl \ ${WRKSRC}/slimserver.pl + sed -i '.bak' \ + -e 's/skip-locking/skip-external-locking/' \ + -e 's/default-character-set/character-set-server/'\ + -e 's/default-collation/collation-server/' ${WRKSRC}/MySQL/my.tt= =20 + sed -i '.bak' \ + -e 's/TYPE=3DInnoDB/ENGINE=3DInnoDB/' ${WRKSRC}/SQL/mysql/schema_*= .sql =20 do-build: @${MKDIR} -m 0755 ${TMP_SLIMDIR} = --_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_ Content-Type: text/html; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable
I have patched the Makefile to make the necessary adjustments so that squee= zeboxserver can be installed and run. =3B

The problem is that w= ith the introduction of MySQL 5.5 some commands are no longer available. Th= ey have been replaced by equivalents.
http://dev.mysql.com/doc/refman/5= .5/en/server-options.html#option_mysqld_skip-external-locking as an example= .

The commands are taken from: http://permalink.gmane.org/gmane.musi= c.equipment.slimdevices.squeezecenter/26896

I = believe applying the patch below is the simplest until upstream gets fixed.= Would be good if this relatively simple patch could be committed.

= --- Makefile =3B =3B =3B 2012-06-21 14:08:40.000000000 +0200+++ Makefile.new =3B =3B =3B 2012-06-21 13:58:08.000000000 +02= 00
@@ -57=2C7 +57=2C6 @@
 =3B.endif
 =3B
 =3BUSE_MY= SQL=3D =3B =3B =3B server
-WANT_MYSQL_VER=3D50
 =3B =3B.if ${PORT_OPTIONS:MAPE}
 =3BRUN_DEPENDS+=3D =3B = =3B =3B mac:${PORTSDIR}/audio/mac
@@ -173=2C6 +172=2C12 @@
 = =3B =3B =3B =3B  =3B =3B =3B -e 's|%%TMP_SLIMDIR%%|= ${TMP_SLIMDIR}|g' \
 =3B =3B =3B =3B  =3B =3B&nb= sp=3B ${WRKSRC}/scanner.pl \
 =3B =3B =3B =3B  =3B&n= bsp=3B =3B ${WRKSRC}/slimserver.pl
+ =3B =3B =3B sed -i = '.bak' \
+ =3B =3B =3B  =3B =3B =3B -e 's/skip-l= ocking/skip-external-locking/' \
+ =3B =3B =3B  =3B = =3B =3B -e 's/default-character-set/character-set-server/'\
+ = =3B =3B =3B  =3B =3B =3B -e 's/default-collation/collat= ion-server/' =3B ${WRKSRC}/MySQL/my.tt
+ =3B =3B =3B se= d -i '.bak' \
+ =3B =3B =3B  =3B =3B =3B -e 's/T= YPE=3DInnoDB/ENGINE=3DInnoDB/' ${WRKSRC}/SQL/mysql/schema_*.sql
 =3B=
 =3Bdo-build:
 =3B =3B =3B =3B @${MKDIR} -m 0755= ${TMP_SLIMDIR}

= --_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_-- --_4281e75e-976c-4a2f-bdf1-085368573516_ Content-Type: application/octet-stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch_squeezeboxserver_Makefile" LS0tIE1ha2VmaWxlCTIwMTItMDYtMjEgMTQ6MDg6NDAuMDAwMDAwMDAwICswMjAwCisrKyBNYWtl ZmlsZS5uZXcJMjAxMi0wNi0yMSAxMzo1ODowOC4wMDAwMDAwMDAgKzAyMDAKQEAgLTU3LDcgKzU3 LDYgQEAKIC5lbmRpZgogCiBVU0VfTVlTUUw9CXNlcnZlcgotV0FOVF9NWVNRTF9WRVI9NTAKIAog LmlmICR7UE9SVF9PUFRJT05TOk1BUEV9CiBSVU5fREVQRU5EUys9CW1hYzoke1BPUlRTRElSfS9h dWRpby9tYWMKQEAgLTE3Myw2ICsxNzIsMTIgQEAKIAkgICAgLWUgJ3N8JSVUTVBfU0xJTURJUiUl fCR7VE1QX1NMSU1ESVJ9fGcnIFwKIAkJJHtXUktTUkN9L3NjYW5uZXIucGwgXAogCQkke1dSS1NS Q30vc2xpbXNlcnZlci5wbAorCXNlZCAtaSAnLmJhaycgXAorCQktZSAncy9za2lwLWxvY2tpbmcv c2tpcC1leHRlcm5hbC1sb2NraW5nLycgXAorCQktZSAncy9kZWZhdWx0LWNoYXJhY3Rlci1zZXQv Y2hhcmFjdGVyLXNldC1zZXJ2ZXIvJ1wKKwkJLWUgJ3MvZGVmYXVsdC1jb2xsYXRpb24vY29sbGF0 aW9uLXNlcnZlci8nICAke1dSS1NSQ30vTXlTUUwvbXkudHQgCisJc2VkIC1pICcuYmFrJyBcCisJ CS1lICdzL1RZUEU9SW5ub0RCL0VOR0lORT1Jbm5vREIvJyAke1dSS1NSQ30vU1FML215c3FsL3Nj aGVtYV8qLnNxbAogCiBkby1idWlsZDoKIAlAJHtNS0RJUn0gLW0gMDc1NSAke1RNUF9TTElNRElS fQo= --_4281e75e-976c-4a2f-bdf1-085368573516_--