From owner-cvs-all@FreeBSD.ORG  Thu Jun  9 18:38:56 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.ORG
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9CA4C16A420
	for <cvs-all@FreeBSD.ORG>; Thu,  9 Jun 2005 18:38:56 +0000 (GMT)
	(envelope-from mohan_srinivasan@yahoo.com)
Received: from web80601.mail.yahoo.com (web80601.mail.yahoo.com [66.218.79.90])
	by mx1.FreeBSD.org (Postfix) with SMTP id F075243D1F
	for <cvs-all@FreeBSD.ORG>; Thu,  9 Jun 2005 18:38:55 +0000 (GMT)
	(envelope-from mohan_srinivasan@yahoo.com)
Message-ID: <20050609183855.25409.qmail@web80601.mail.yahoo.com>
Received: from [207.126.239.39] by web80601.mail.yahoo.com via HTTP;
	Thu, 09 Jun 2005 11:38:55 PDT
Date: Thu, 9 Jun 2005 11:38:55 -0700 (PDT)
From: Mohan Srinivasan <mohan_srinivasan@yahoo.com>
To: Andrey Chernov <ache@nagual.pp.ru>, Paul Saab <ps@FreeBSD.ORG>
In-Reply-To: 6667
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/netinet tcp_sack.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jun 2005 18:38:56 -0000

Merge snafu on my part.

Fix committed now.

mohan

--- Andrey Chernov <ache@nagual.pp.ru> wrote:
> On Thu, Jun 09, 2005 at 02:01:04PM +0000, Paul Saab wrote:
> >   Modified files:
> >     sys/netinet          tcp_sack.c 
> >   Log:
> >   Fix for a crash in tcp_sack_option() caused by hitting the limit on
> >   the number of sack holes.
> 
> Some cut&paste mistake obviously happens. I see now _two_ identical
> tcp_sackhole_insert() in tcp_sack.c v1.23:
> 
>                 temp = tcp_sackhole_insert(tp, tp->snd_fack,sblkp->start,NULL);
>                 if (temp == NULL)
>                         return 0;
>                 tcp_sackhole_insert(tp, tp->snd_fack, sblkp->start, NULL);
> 
> -- 
> http://ache.pp.ru/
>