From owner-svn-src-all@freebsd.org Sat Jul 27 01:35:08 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5C7EADD5C; Sat, 27 Jul 2019 01:35:08 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670060.outbound.protection.outlook.com [40.107.67.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 93C168B55F; Sat, 27 Jul 2019 01:35:08 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FguftwrYaHT8WsBfQwTIbchYd6JAUp/CsLo6YTOCCsxpg5Ru+9iTaOQfcNYf6qApmLeqrC+opprkGu4vJmYlgdnQ1YZtiPBZT2KTFToH/sNqPZq5mCOFdVU66Wl2mltI6ngUGg6y+XPPkqP1eEIOOMnnynliQwrQkb5Oilx0wbL6lG56wCAXkx90bafBFbWhFgvJrV0SQ+QZmVDtzqBlxKiQh86McQPLpJBgLWONUST0xo4mZUuzS7B81hn4aLEsjBC7PnBek3tQ4dfmdzxGiagsHq+YagM/qz+BbD5TcSsXb6hBNKlr17S9vb8TWCnB54hAQdBPtz04b/dE1o92Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gGbIl/w7eO6GiSVuDUdKXzwlVsh1pZSA0cUVeCKgnZo=; b=a2Jo4F+3I964P9pvaDjo02XQA4JhUnw8tUvIhzZu7VbxghCBUKdOj9sgmtviAw9MlPw9/SCMtWoBBUUNirz8uiXQkleqargOLdZjkZdfO5fSRAYYU29X3/wXtKutBQ5XXKpfaZUUnrjEdZpzKj+GpUFUvH2WQrLqovGfqtovhu5ZX/O3GZLMm+oTZ1Nxi8XpXUwXtBfuH7VbaLBDhrBYkAjYsnFoMrs1rLS/yX1UnyMb00vAB/AsQvfxEyGsKSn1OPUUyhyhL1ZB3Jt/QORfOgWMD8r36iPSzXyXTNollbrbXm/1tmRPt7D6KwAuHEqS2Y7fhLbxMLoMucx48WAHTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=uoguelph.ca;dmarc=pass action=none header.from=uoguelph.ca;dkim=pass header.d=uoguelph.ca;arc=none Received: from YTBPR01MB3312.CANPRD01.PROD.OUTLOOK.COM (10.255.13.158) by YTBPR01MB3486.CANPRD01.PROD.OUTLOOK.COM (10.255.47.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Sat, 27 Jul 2019 01:35:06 +0000 Received: from YTBPR01MB3312.CANPRD01.PROD.OUTLOOK.COM ([fe80::70d6:627b:b391:3977]) by YTBPR01MB3312.CANPRD01.PROD.OUTLOOK.COM ([fe80::70d6:627b:b391:3977%7]) with mapi id 15.20.2115.005; Sat, 27 Jul 2019 01:35:06 +0000 From: Rick Macklem To: Konstantin Belousov , Rick Macklem CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r350315 - in head/sys: kern sys Thread-Topic: svn commit: r350315 - in head/sys: kern sys Thread-Index: AQHVQ/0DsB7s4Yi/T0Guwd+l7YYIgqbdrdDe Date: Sat, 27 Jul 2019 01:35:06 +0000 Message-ID: References: <201907250546.x6P5kHWq076756@repo.freebsd.org>, <20190726215628.GE2731@kib.kiev.ua> In-Reply-To: <20190726215628.GE2731@kib.kiev.ua> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9acca05-368a-4118-0a42-08d71232a7a3 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YTBPR01MB3486; x-ms-traffictypediagnostic: YTBPR01MB3486: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-forefront-prvs: 01110342A5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(366004)(396003)(39860400002)(189003)(199004)(305945005)(966005)(6246003)(6506007)(76116006)(52536014)(8936002)(316002)(66556008)(66446008)(5660300002)(14454004)(786003)(64756008)(66476007)(74316002)(66946007)(86362001)(229853002)(99286004)(6436002)(76176011)(7696005)(25786009)(256004)(33656002)(4326008)(9686003)(71200400001)(110136005)(53936002)(68736007)(81166006)(11346002)(54906003)(446003)(71190400001)(2906002)(81156014)(102836004)(186003)(6306002)(55016002)(478600001)(486006)(46003)(476003)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB3486; H:YTBPR01MB3312.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jhtzy5dQY+74HE6W4dx6jWqK1D0N4GebcFQCMCD+HpdTQ+w9BtruxcUqCtCbjEsc91OxQ1V4drHtYCtVhnUrrDgUVT2o7Xo2YuRg4qApDgIStPMGHiEtExlAhNBJHiDW1+lriWzVKF7Q2mpa/0QSSQjrLL1gE+eauQsd9eqr100QfJCpji/HuO6a6DaB1ckC0HBv+sE/iuJ/OI1X2gup1PxFF0qHtZWDI97hXUwS+jdkdfsCkC4ACKBnDmX8i7QWHN1TWzw65rJxEIS+E7b7IS6U3DRf9S8EWJ/hdfcV6au9YNIZcAELUWAKUe30vvrXFJuKGLYIneLnp2pRfk4NgyNOQ9lgb+A5pufkRFGHpOvZaxlOfQ3jnTR7H+62BMAMS3dr8FP2Hz4/qXz6RPTLBERqfhCHaGmVAnsHQs+2NwQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: f9acca05-368a-4118-0a42-08d71232a7a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2019 01:35:06.5379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB3486 X-Rspamd-Queue-Id: 93C168B55F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.89 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.89)[-0.894,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2019 01:35:08 -0000 Konstantin Belousov wrote: >On Thu, Jul 25, 2019 at 05:46:17AM +0000, Rick Macklem wrote: >> Author: rmacklem >> Date: Thu Jul 25 05:46:16 2019 >> New Revision: 350315 >> URL: https://svnweb.freebsd.org/changeset/base/350315 >> >> Log: >> Add kernel support for a Linux compatible copy_file_range(2) syscall. > >> Modified: head/sys/kern/syscalls.master >> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> --- head/sys/kern/syscalls.master Thu Jul 25 03:55:05 2019 (r= 350314) >> +++ head/sys/kern/syscalls.master Thu Jul 25 05:46:16 2019 (r= 350315) >> @@ -3175,6 +3175,16 @@ >> int flag >> ); >> } >> +569 AUE_NULL STD { >> + ssize_t copy_file_range( >> + int infd, >> + _Inout_opt_ off_t *inoffp, >> + int outfd, >> + _Inout_opt_ off_t *outoffp, >> + size_t len, >> + unsigned int flags >> + ); >> + } > >I sat to write the compat32 shims, and only then noted that len has size_t >type. Why is it size_t and not off_t ? Well, that's what Linux did. Also, since it returns ssize_t, it can't do more than SSIZE_MAX (generally = 1/2 of SIZE_T_MAX). Returning ssize_t is also what Linux does and is consistent wi= th read(2)/write(2). rick