From owner-freebsd-wireless@FreeBSD.ORG Thu Oct 24 01:05:50 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 60550CC3 for ; Thu, 24 Oct 2013 01:05:50 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qa0-x229.google.com (mail-qa0-x229.google.com [IPv6:2607:f8b0:400d:c00::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2045B2DED for ; Thu, 24 Oct 2013 01:05:50 +0000 (UTC) Received: by mail-qa0-f41.google.com with SMTP id f11so4716368qae.14 for ; Wed, 23 Oct 2013 18:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=bkFN4lsLgBfDs/s0x3cpY0lI57N3LNW5nIuI67QigIw=; b=lRytc/uRERsWjL5RlgyLOl8pZa7YdJGrgnF9hRE5UREjZ7tCkYq1R/YiaBAnCGwE18 KDgND8GZFqOgH6/v2PAyP2C/+Zx5z5r2T+4YbnqFlzK6/9P1ouJ23xVPLrTNrS7VN8l1 1SiFUuMbK1JDLuHtTvahC3uWaeHyWy/WIPtg0Dl6svIb3FGa8o9uCmGNKQS5yzaUHIb/ /vrYxy+dX6TA3S+zhYsTFSvqIkmU/yL//r6EJiVdnOB7UrQpJkX6ht0CtOp2BkqjIjUe CD63CG2+m/dEe2HzwCusA7pWF0LjrU/nCb/WDI26B7QzeFj1y/sAmo5YyImk0+yZE7V3 S0Gg== MIME-Version: 1.0 X-Received: by 10.224.161.83 with SMTP id q19mr759437qax.92.1382576749267; Wed, 23 Oct 2013 18:05:49 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.207.66 with HTTP; Wed, 23 Oct 2013 18:05:49 -0700 (PDT) In-Reply-To: References: <002701cebc6f$634c0040$29e400c0$@info> Date: Wed, 23 Oct 2013 18:05:49 -0700 X-Google-Sender-Auth: TpzcnLYXs8zj4a5QXa-jh7Q5yM0 Message-ID: Subject: Re: [IWN] Review From: Adrian Chadd To: Cedric GROSS Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Oct 2013 01:05:50 -0000 .. and I've just done the if_iwn_debug.h stuff, so you should update your patchset to include that. Thanks, -adrian On 23 October 2013 17:43, Adrian Chadd wrote: > Hi, > > Ok. I've reviewed this stuff in more depth. > > Split-6 is still way too big to commit as one commit. > > I was also hoping that we could get the updated hardware support into this > without necessarily adding the PAN support. But, you're the one driving > this, so it's up to you. :) > > * There's DPRINTF() and the debug flags that you've moved into > if_iwnreg.h, which is the wrong place for it! > * .. same as iwn_intr_str() > * You still have style(9) issues: > + the "if" constructs should be if (), not if(); > + you need spaces between things - eg, if (a == b) rather than if(a==b) > or if (a==b); > + the } else { should be on one line, not separate on multiple lines. > > * What's the story behind sc->ctx? When is it being set/changed? > * And then there's also ivp->ctx; that's the current VAP context, right? > If that's the case ,why are we bothering checking unit number? Why don't we > consistently check the vap context? > > So, let's break up split_6 into this: > > * create if_iwn_debug.h; put the debug macros, enum and such into that; > * submit a patch _just_ for the debug work, that's easy to do. > > * Then, fix up the style(9) issues. > * Then, help me figure out what the story is with sc->ctx so I understand > what's going on there. I'd like to try and remove that if possible. > > Thanks, > > > > -adrian > > > > On 28 September 2013 10:23, Cedric GROSS wrote: > >> Hello, >> >> >> >> I'm get some free time. So I setted up my github for split work. >> >> >> >> So on https://github.com/KreizIT/FreeBSD-IWN/ >> >> >> >> You will find 2 new branch : split_6 and split_7. >> >> >> >> Split_6 is iwn -HEAD with split 6 applied. Patch for that is also >> available >> in this branch. >> >> Split_7 is iwn -HEAD with split 6 and new split 7 applied. >> >> >> >> Split_7 start "parameters task". So no massive change except that it's >> manage NIC without BT. >> >> >> >> Regards >> >> Cedric >> >> _______________________________________________ >> freebsd-wireless@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless >> To unsubscribe, send any mail to " >> freebsd-wireless-unsubscribe@freebsd.org" >> > >