From owner-freebsd-current Wed May 17 13:55:45 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id NAA14373 for current-outgoing; Wed, 17 May 1995 13:55:45 -0700 Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.97.216]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id NAA14367 for ; Wed, 17 May 1995 13:55:43 -0700 Received: (from kargl@localhost) by troutmask.apl.washington.edu (8.6.11/8.6.9) id NAA00355; Wed, 17 May 1995 13:51:20 -0700 From: Steven G Kargl Message-Id: <199505172051.NAA00355@troutmask.apl.washington.edu> Subject: Re: please test this patch for panic("swfree") To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Wed, 17 May 1995 13:51:20 -0700 (PDT) Cc: phk@ref.tfs.com, current@FreeBSD.org In-Reply-To: <199505172008.NAA12294@gndrsh.aac.dev.com> from "Rodney W. Grimes" at May 17, 95 01:08:43 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 929 Sender: current-owner@FreeBSD.org Precedence: bulk According to Rodney W. Grimes: > > > > > for (dvbase = dmmax; dvbase < nblks; dvbase += dmmax) { > > blk = nblks - dvbase; > > > > - if ((vsbase = index * dmmax + dvbase * nswdev) >= nswap) > > - panic("swfree"); > > Not Okay, please correct the calculation to do the right check, not > eliminate the sanify check. > > > - if (blk > dmmax) > > - blk = dmmax; > > Should this be another panic condition??? > > > /* XXX -- we need to exclude the first cluster as above */ > > /* but for now, this will work fine... */ > > rlist_free(&swaplist, vsbase, vsbase + blk - 1); > > Yes, you get another panic. panic: rlist_free: free start overlaps already freed area at list tail -- Steven G. Kargl | Phone: 206-685-4677 | Applied Physics Lab | Fax: 206-543-6785 | Univ. of Washington |---------------------| 1013 NE 40th St | FreeBSD 2.1-current | Seattle, WA 98105 |---------------------|