Date: Tue, 13 Sep 2016 22:49:08 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Michael Reifenberger <mr@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r422061 - in head/comms/uhd: . files Message-ID: <2fc3d1fd-f23a-e895-6595-f2cfda0967ff@FreeBSD.org> In-Reply-To: <201609131858.u8DIwelq007807@repo.freebsd.org> References: <201609131858.u8DIwelq007807@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--MLAAe3xqqefKNAJnxoIV3eVkEGf5PRUXR
Content-Type: multipart/mixed; boundary="7BA9sUhX5q3iBUTpkWth02UXARJ0lev78";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Michael Reifenberger <mr@FreeBSD.org>, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <2fc3d1fd-f23a-e895-6595-f2cfda0967ff@FreeBSD.org>
Subject: Re: svn commit: r422061 - in head/comms/uhd: . files
References: <201609131858.u8DIwelq007807@repo.freebsd.org>
In-Reply-To: <201609131858.u8DIwelq007807@repo.freebsd.org>
--7BA9sUhX5q3iBUTpkWth02UXARJ0lev78
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Le 13/09/2016 =C3=A0 20:58, Michael Reifenberger a =C3=A9crit :
> +EXTRACT_ONLY=3D ${DISTFILES}
That is not needed, it is the default.
> +GH_TAGNAME=3D ${UHD_COMMIT}
> +
> +UHD_COMMIT=3D 32951af2f3e7b1ddb56486c9f15b2e1033605bd6
I'm not sure using a second variable only once is needed.
> +COMPILER_FEATURES=3D libc++
That variable is *read-only*, writing to it makes no sense.
> +MAKE_JOBS_UNSAFE=3D yes
When adding MAKE_JOBS_UNSAFE, you have to say why it does not build with
make -j.
> +DOCSDIR=3D share/doc/uhd
This is the default and not needed.
> +.if ${OSVERSION} < 800000
> +IGNORE=3D needs libusb 1.0
> +.endif
Adding that OSVERSION check makes no sense, no release before 9 will
work with the current ports tree.
> +.if ${PORT_OPTIONS:MDOCS}
> +BUILD_DEPENDS+=3D doxygen:${PORTSDIR}/devel/doxygen
> +CMAKE_ARGS+=3D -DENABLE_DOXYGEN:STRING=3D"ON"
> +HAVEDOCS=3D YES
> +.endif
Do not add doxygen as a dependency with a DOCS option, use a DOXYGEN one.=
> +- DESTINATION ${LIBRARY_DIR}/pkgconfig
> ++ DESTINATION libdata/pkgconfig
This is handled by USES=3Dpathfix.
--=20
Mathieu Arnold
--7BA9sUhX5q3iBUTpkWth02UXARJ0lev78--
--MLAAe3xqqefKNAJnxoIV3eVkEGf5PRUXR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJX2GZEXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I3ssP/jsMD1AOmSjdegknKuV1qmng
zEjF0Qsla39Io8YDyQGmEWvMD2jDIooOp8BAbXiZWMmDDs14zBuXWnYLhsNKvo3d
w/h0yfJ7UH/01d76Pw5L5RuUjlMgXnxln0PXb9Au1Ok83lEnHJQf38/2TJ60Tkju
8A1pwWk5aJ/oYJ8UhcM/0mXanwuZxpHZaM+sPMdT1u9kxPw1p86I9TL+ZZO+uWjQ
gCWlqvhjN8hCKIlK1XqxRxqzjohrRK2J0y7egoEBMdO1mI/giDddkeGlNxOMydxw
8mcDdeUeGyv6OyNOsFtZi3ZzbUHAsFiabhTs1A7+T0n8wgaFVHwBlzeTrfiBTXV0
YOFK/SJXJCwqW7siKEZWa7bF9Gse6n5ErJvegRcAEOIPqELHspd//X45Z1jRsz+3
7XIdxIxeHgseD9MMtjP3FrwnYoZinkJoIHyWFRkn1iswd/hTwunaJ4f0x5HbUS/4
vVCgf/k9Z8dGDM2m9tlELhM6zZElXiB6DehYT9eyPHcp02Mn2Ou7r3CsyMAt2I3B
3xKwGPw85WENwoq2IyAJXtxGIPrwLIVaUYSk+8ulUGcVo6arsrXEXUgUkIsTqzIF
rYPaj3t9+hbho51wJbz8SIBiOA0xrA4l+MtyyLB1n8uRZJvs4bgW8kEK3ygzIsJG
kSZ6ekuRMuGpHLOUdamh
=0dMG
-----END PGP SIGNATURE-----
--MLAAe3xqqefKNAJnxoIV3eVkEGf5PRUXR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2fc3d1fd-f23a-e895-6595-f2cfda0967ff>