From owner-svn-src-stable-8@FreeBSD.ORG Mon Dec 7 20:51:34 2009 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0AB99106568F; Mon, 7 Dec 2009 20:51:34 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id B541F8FC19; Mon, 7 Dec 2009 20:51:33 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.3/8.14.3) with ESMTP id nB7KHjE4077310; Mon, 7 Dec 2009 14:17:45 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.3/8.14.3/Submit) id nB7KHjH9077309; Mon, 7 Dec 2009 14:17:45 -0600 (CST) (envelope-from brooks) Date: Mon, 7 Dec 2009 14:17:44 -0600 From: Brooks Davis To: Luigi Rizzo Message-ID: <20091207201744.GA77256@lor.one-eyed-alien.net> References: <200912061901.nB6J1X7L028816@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline In-Reply-To: <200912061901.nB6J1X7L028816@svn.freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Mon, 07 Dec 2009 14:17:45 -0600 (CST) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r200184 - stable/8/sbin/ipfw X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2009 20:51:34 -0000 --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 06, 2009 at 07:01:33PM +0000, Luigi Rizzo wrote: > Author: luigi > Date: Sun Dec 6 19:01:33 2009 > New Revision: 200184 > URL: http://svn.freebsd.org/changeset/base/200184 >=20 > Log: > mfc r200056 > use qsort_r instead of heapsort; This seems like a move in the wrong direction. The use of a recursive algorithm in the kernel seems generally ill-advised and I was rather disturbed when I found we had a quick sort implementation in libkern. Unless you know the number of items is small, quick sort isn't safe and if the number is small, heap sort is plenty efficient. -- Brooks --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFLHWLoXY6L6fI4GtQRArluAJ9dOCmyxtl1sioZn6e4akpWFqD1wwCgrnc9 OUdu3HYsdlTRtnocrHF6/y8= =VNea -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--