From owner-svn-src-all@freebsd.org Wed Jun 6 06:43:01 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1DEDFE6EB7 for ; Wed, 6 Jun 2018 06:43:00 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F4D986B59 for ; Wed, 6 Jun 2018 06:43:00 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yw0-f170.google.com (mail-yw0-f170.google.com [209.85.161.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id 5A0A6239BC for ; Wed, 6 Jun 2018 06:43:00 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yw0-f170.google.com with SMTP id b125-v6so1557510ywe.1 for ; Tue, 05 Jun 2018 23:43:00 -0700 (PDT) X-Gm-Message-State: APt69E21+F4ZhEt+/Xa2jSC3XCrG75uuKx6t6yXdLLCVPMd+kQliEHBP M0YNaOFFDse4OXuZWU3IO+XRUOcTs8wpY/Vubm7xRQ== X-Google-Smtp-Source: ADUXVKJkr1lDTFHFVa+FE8Pg0UEqaqkKTYyArHa8Qv9OYpBXLW6m8DMBlRkvzGGtcJ82OUQjwWYeLoR+CjiA0xIatqY= X-Received: by 2002:a81:b70b:: with SMTP id v11-v6mr790600ywh.182.1528267379808; Tue, 05 Jun 2018 23:42:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Tue, 5 Jun 2018 23:42:29 -0700 (PDT) In-Reply-To: <20180604054240.bgzlzftyw2zaxwa4@ivaldir.net> References: <201806031341.w53DfOAD000819@repo.freebsd.org> <20180604054240.bgzlzftyw2zaxwa4@ivaldir.net> From: Eitan Adler Date: Tue, 5 Jun 2018 23:42:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334557 - head/usr.bin/top To: Baptiste Daroussin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2018 06:43:01 -0000 On 3 June 2018 at 22:42, Baptiste Daroussin wrote: > On Sun, Jun 03, 2018 at 01:41:24PM +0000, Eitan Adler wrote: >> Author: eadler >> Date: Sun Jun 3 13:41:23 2018 >> New Revision: 334557 >> URL: https://svnweb.freebsd.org/changeset/base/334557 >> >> Log: >> top(1): restore size for kern.cp_times >> >> Restore last minute change that broke top(1). >> >> Modified: >> head/usr.bin/top/machine.c >> >> Modified: head/usr.bin/top/machine.c >> ============================================================================== >> --- head/usr.bin/top/machine.c Sun Jun 3 13:40:58 2018 (r334556) >> +++ head/usr.bin/top/machine.c Sun Jun 3 13:41:23 2018 (r334557) >> @@ -384,6 +384,7 @@ machine_init(struct statics *statics) >> times = calloc(maxcpu * CPUSTATES, sizeof(long)); >> if (times == NULL) >> err(1, "calloc %zu bytes", size); >> + size = sizeof(long) * maxcpu * CPUSTATES; > > The error message just above might also be unhappy about the size variable :) r334704 - thanks! -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams