Date: Tue, 5 Jun 2018 23:42:29 -0700 From: Eitan Adler <eadler@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334557 - head/usr.bin/top Message-ID: <CAF6rxg=iqSxjTAdKPv-EkAEw-MF7DAPXE%2BXn6Y=6keCd8bVGyw@mail.gmail.com> In-Reply-To: <20180604054240.bgzlzftyw2zaxwa4@ivaldir.net> References: <201806031341.w53DfOAD000819@repo.freebsd.org> <20180604054240.bgzlzftyw2zaxwa4@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 June 2018 at 22:42, Baptiste Daroussin <bapt@freebsd.org> wrote: > On Sun, Jun 03, 2018 at 01:41:24PM +0000, Eitan Adler wrote: >> Author: eadler >> Date: Sun Jun 3 13:41:23 2018 >> New Revision: 334557 >> URL: https://svnweb.freebsd.org/changeset/base/334557 >> >> Log: >> top(1): restore size for kern.cp_times >> >> Restore last minute change that broke top(1). >> >> Modified: >> head/usr.bin/top/machine.c >> >> Modified: head/usr.bin/top/machine.c >> ============================================================================== >> --- head/usr.bin/top/machine.c Sun Jun 3 13:40:58 2018 (r334556) >> +++ head/usr.bin/top/machine.c Sun Jun 3 13:41:23 2018 (r334557) >> @@ -384,6 +384,7 @@ machine_init(struct statics *statics) >> times = calloc(maxcpu * CPUSTATES, sizeof(long)); >> if (times == NULL) >> err(1, "calloc %zu bytes", size); >> + size = sizeof(long) * maxcpu * CPUSTATES; > > The error message just above might also be unhappy about the size variable :) r334704 - thanks! -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=iqSxjTAdKPv-EkAEw-MF7DAPXE%2BXn6Y=6keCd8bVGyw>