Date: Tue, 21 Jan 2025 10:25:21 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org> To: Vladimir Druzenko <vvd@freebsd.org> Cc: Charlie Li <vishwin@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: e94a554e5542 - main - net/libproxy: bump consumers Message-ID: <20250121102511.211135db@hal.tijl.coosemans.org> In-Reply-To: <365f4bcd-67c6-406a-ab09-c183760ee2b4@freebsd.org> References: <202501200502.50K52FZ0040498@gitrepo.freebsd.org> <365f4bcd-67c6-406a-ab09-c183760ee2b4@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--MP_/IQvGm=a9McguHZITt5c4SW2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Mon, 20 Jan 2025 13:09:07 +0300 Vladimir Druzenko wrote: > 20.01.2025 08:02, Charlie Li =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> The branch main has been updated by vishwin: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=3De94a554e5542a7f4a03dfc0= 04d22f21635446626 >> >> commit e94a554e5542a7f4a03dfc004d22f21635446626 >> Author: Charlie Li <vishwin@FreeBSD.org> >> AuthorDate: 2025-01-20 04:58:55 +0000 >> Commit: Charlie Li <vishwin@FreeBSD.org> >> CommitDate: 2025-01-20 05:01:30 +0000 >> >> net/libproxy: bump consumers >> =20 >> PR: 284088 >> --- >> irc/hexchat/Makefile | 1 + >> net/glib-networking/Makefile | 1 + >> security/beid/Makefile | 1 + >> sysutils/signon-ui/Makefile | 2 +- >> 4 files changed, 4 insertions(+), 1 deletion(-) =20 >=20 > Hello! >=20 > $ firefox > XPCOMGlueLoad error for file /usr/local/lib/firefox/libxul.so: > /usr/local/lib/libproxy.so.1: version LIBPROXY_0.4.16 required by=20 > /usr/local/lib/firefox/libxul.so not defined This error means there's something wrong with symbol versioning in libproxy. The meson output contains this line: Compiler for C supports link arguments -Wl,--version-script,/usr/ports/net/= libproxy/work/libproxy-0.5.9/src/libproxy/libproxy.map: NO The details are in _build/meson-logs/meson-log.txt: Command line: `cc /usr/ports/net/libproxy/work/libproxy-0.5.9/_build/meson-= private/tmpxpd8ylph/testfile.c -o /usr/ports/net/libproxy/work/libproxy-0.5= .9/_build/meson-private/tmpxpd8ylph/output.exe -O2 -pipe -fstack-protector-= strong -fno-strict-aliasing -D_FILE_OFFSET_BITS=3D64 -O0 -Werror=3Dimplicit= -function-declaration -Wl,--fatal-warnings -Wl,--version-script,/tmp/obj/us= r/freebsd/ports/main/net/libproxy/work/libproxy-0.5.9/src/libproxy/libproxy= .map` -> 1 stderr: ld: error: version script assignment of 'LIBPROXY_0.4.16' to symbol 'px_pro= xy_factory_new' failed: symbol not defined ld: error: version script assignment of 'LIBPROXY_0.4.16' to symbol 'px_pro= xy_factory_get_proxies' failed: symbol not defined ld: error: version script assignment of 'LIBPROXY_0.4.16' to symbol 'px_pro= xy_factory_free_proxies' failed: symbol not defined ld: error: version script assignment of 'LIBPROXY_0.4.16' to symbol 'px_pro= xy_factory_free' failed: symbol not defined ld: error: version script assignment of 'LIBPROXY_0.5.5' to symbol 'px_prox= y_factory_get_type' failed: symbol not defined ld: error: version script assignment of 'LIBPROXY_0.5.5' to symbol 'px_prox= y_factory_copy' failed: symbol not defined clang: error: linker command failed with exit code 1 (use -v to see invocat= ion) Clang is more strict than gcc about this. The attached patches should fix it. --MP_/IQvGm=a9McguHZITt5c4SW2 Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=patch-src_libproxy_empty.map --- src/libproxy/empty.map.orig 2025-01-21 09:08:24 UTC +++ src/libproxy/empty.map @@ -0,0 +1,5 @@ +LIBPROXY_0.4.16 { +}; + +LIBPROXY_0.5.5 { +} LIBPROXY_0.4.16; --MP_/IQvGm=a9McguHZITt5c4SW2 Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=patch-src_libproxy_meson.build --- src/libproxy/meson.build.orig 2024-10-02 14:22:15 UTC +++ src/libproxy/meson.build @@ -15,10 +15,10 @@ mapfile =3D 'libproxy.map' ] =20 mapfile =3D 'libproxy.map' -vscript =3D '-Wl,--version-script,@0@/@1@'.format(meson.current_source_dir= (), mapfile) +vscript =3D '-Wl,--version-script=3D' + meson.current_source_dir() vflag =3D [] -if cc.has_multi_link_arguments(vscript) - vflag +=3D vscript +if cc.has_multi_link_arguments(vscript / 'empty.map') + vflag +=3D vscript / mapfile endif =20 libproxy =3D shared_library( --MP_/IQvGm=a9McguHZITt5c4SW2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20250121102511.211135db>