From owner-freebsd-acpi@FreeBSD.ORG Wed Nov 17 19:50:21 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E004F16A4D0 for ; Wed, 17 Nov 2004 19:50:21 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C60943D66 for ; Wed, 17 Nov 2004 19:50:21 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4303 invoked from network); 17 Nov 2004 19:50:21 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 17 Nov 2004 19:50:20 -0000 Received: from [10.50.41.235] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iAHJoBnu092049; Wed, 17 Nov 2004 14:50:16 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Ruslan Ermilov Date: Wed, 17 Nov 2004 11:24:48 -0500 User-Agent: KMail/1.6.2 References: <200411111737.00537.jhb@FreeBSD.org> <200411161339.13818.jhb@FreeBSD.org> <20041117154146.GD25995@ip.net.ua> In-Reply-To: <20041117154146.GD25995@ip.net.ua> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411171124.48268.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: acpi@FreeBSD.org cc: freebsd-acpi@FreeBSD.org cc: gallatin@FreeBSD.org cc: scottl@FreeBSD.org Subject: Re: New ACPI PCI Link Routing code X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2004 19:50:22 -0000 On Wednesday 17 November 2004 10:41 am, Ruslan Ermilov wrote: > On Tue, Nov 16, 2004 at 01:39:13PM -0500, John Baldwin wrote: > > On Thursday 11 November 2004 05:37 pm, John Baldwin wrote: > > > I've done some work on the ACPI PCI link code to make it a bit more > > > like $PIR in that it is link centric and uses actual new-bus devices > > > for each device link. One benefit of this is that unused links will be > > > disabled now which might help with interrupt aliasing problems on > > > machines using APICs. Also, instead of routing IRQs for links via PCI > > > device numbers using tunables, they are now routed via the link name > > > ala $PIR. Thus, one uses 'hw.pci.link.LNKA.irq=X' to route LNKA to IRQ > > > X. Also, when choosing a virgin interrupt, we no longer try to guess > > > at which IRQs might be used by ISA devices. Instead, we only use > > > known-good IRQs including IRQs that the BIOS has already used and the > > > SCI if the link is being routed via ISA IRQs. The patch is at > > > http://www.FreeBSD.org/~jhb/patches/acpi_pci_link.patch Please test and > > > let me know if there are any problems, thanks. > > > > I've updated this to the latest current and verified that it compiles ok > > (since I had at least one report that it didn't patch cleanly and/or > > compile). I plan to commit this in a couple of days unless I hear some > > sort of negative feedback. > > I get a panic on boot with this change. I don't have a serial > console attached to this notebook, but if needs be it can be > arranged (tomorrow). The panic I get is as follows: > > panic: Assertion resource->Data.Irq.NumberOfInterrupts == 1 failed at > .../acpi_pci_link.c:497 Can you print out what 'NumberOfInterrupts' is before the printf? Drew has a machine that has hit the same panic as well. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org