From owner-freebsd-current Sat Jan 16 22:04:32 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA08031 for freebsd-current-outgoing; Sat, 16 Jan 1999 22:04:32 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA08025 for ; Sat, 16 Jan 1999 22:04:30 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id RAA02965 for current@freebsd.org; Sun, 17 Jan 1999 17:04:24 +1100 Date: Sun, 17 Jan 1999 17:04:24 +1100 From: Bruce Evans Message-Id: <199901170604.RAA02965@godzilla.zeta.org.au> To: current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa wd.c wdreg.h src/sys/pci ide_pci.c Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Watch out for bugs awoken by this. >bde 1999/01/16 21:46:25 PST > > Modified files: > sys/i386/isa wd.c wdreg.h > sys/pci ide_pci.c > Log: > Pass the unit number to the DMA cookie lookup routine and use it > to look up cookies properly, at least for standard controllers. > Cookies are used so that we don't have to pass around lots of args. > All of the dmainit functions use the unit number so it is essential > that we pass them a cookie with the correct unit number. > > This may break working configurations if there are bugs in the > dmainit functions like the ones I just fixed for VIA chipsets. > > Broken in: rev 1.4 of ide_pci.c and rev.1.139 of wd.c. > > Revision Changes Path > 1.186 +5 -3 src/sys/i386/isa/wd.c > 1.25 +2 -2 src/sys/i386/isa/wdreg.h > 1.28 +6 -5 src/sys/pci/ide_pci.c Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message