From owner-freebsd-elastic@freebsd.org Tue Feb 11 22:49:12 2020 Return-Path: Delivered-To: freebsd-elastic@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 08BAE245D04 for ; Tue, 11 Feb 2020 22:49:12 +0000 (UTC) (envelope-from SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48HHyH3kjHz4m46 for ; Tue, 11 Feb 2020 22:49:11 +0000 (UTC) (envelope-from SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz) Received: by mailman.nyi.freebsd.org (Postfix) id 80131245D03; Tue, 11 Feb 2020 22:49:11 +0000 (UTC) Delivered-To: elastic@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7FDBF245D02 for ; Tue, 11 Feb 2020 22:49:11 +0000 (UTC) (envelope-from SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48HHyG0bZsz4m45 for ; Tue, 11 Feb 2020 22:49:09 +0000 (UTC) (envelope-from SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 11D5B28417; Tue, 11 Feb 2020 23:49:07 +0100 (CET) Received: from illbsd.quip.test (ip-62-24-92-232.net.upcbroadband.cz [62.24.92.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 4F05728416; Tue, 11 Feb 2020 23:49:05 +0100 (CET) Subject: Re: Beats port update - 7.5.2 To: Paul Godard , elastic@freebsd.org References: From: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: Date: Tue, 11 Feb 2020 23:49:05 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48HHyG0bZsz4m45 X-Spamd-Bar: +++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz has no SPF policy when checking 94.124.105.4) smtp.mailfrom=SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz X-Spamd-Result: default: False [3.57 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(0.85)[ip: (0.33), ipnet: 94.124.104.0/21(0.16), asn: 42000(3.68), country: CZ(0.09)]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[quip.cz]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.51)[0.515,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[4.105.124.94.list.dnswl.org : 127.0.10.0]; NEURAL_SPAM_LONG(1.00)[0.999,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[000.fbsd@quip.cz,SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz]; FREEMAIL_TO(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ]; FROM_NEQ_ENVFROM(0.00)[000.fbsd@quip.cz,SRS0=das0=37=quip.cz=000.fbsd@elsa.codelab.cz]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-elastic@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Support of ElasticSearch-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Feb 2020 22:49:12 -0000 Paul Godard wrote on 2020/02/11 23:35: > Hello maintainer(s)! > > I've been working on an update to the "beats" port for the past week or so. > I've upgraded it to version 7.5.2, and fixed a few things here and there. I > wanted to reach out to you as the maintainer(s) of the port to share my > work and/or understand why you might have kept the current port on version > 6.x. > > I've been mainly testing PacketBeat and MetricBeat (on FreeBSD 11.2 and > pfSense 2.4.4, which also happens to run FreeBSD 11.2), but also ensured > that HeartBeat and FileBeat are working. I've shared this development port > with a few other folks just to get better testing results (all of these > folks are testing this on pfSense 2.4.4 as well). Full disclosure, I > haven't had the time to test this properly on up-to-date builds of FreeBSD > such as 11.3 or 12.x (my goal is to run this on pfSense so I've been > focusing on FreeBSD 11.2 for that reason). I have compiled and packaged the > port on 11.3, but did not spend much time testing it other than ensuring > each beats application starts up and actually pushes data to ES. > > My high-level change log is as follows: > - Upgraded to 7.5.2 > - Fixed warnings at compile time (fixed bash to sh test conditions) > - Cleared up compile/package output (it was quite noisy, portlint doesn't > like this though) > - Fixed compile issue with PacketBeat (it's now compiling and working) > - Fixed packaged dashboards so that they can be installed using "setup > --dashboards" (depends on python 2.7 to achieve this during port building - > python isn't required to run packaged port however) > - Properly generate and include fields.yml for each beats in package > - Fixed memory and socket reporting in MetricBeats > - Updated all beats paths to regroup files as per Elastic's default > directory layout (but using the equivalent paths for FreeBSD) > - Changed default beats configs to remove unsupported processors (docker > and kubernetes) > > I'm still testing this port, but I feel like it's getting pretty close to > being ready for prime-time. I've posted my current SVN diff here if you > would like to take a peek at my changes: https://pastebin.com/PAQWpmKZ. > > Feel free to comment on my changes; I'm by no means an expert at these > ports (I'm learning though!). If you feel this is good enough to submit a > PR, let me know, I can take care of that once I'm comfortable with the > build. Or if you prefer to submit the PR with my SVN diff as the > maintainer(s), I have no problem with that either... Hello, first of all - I am not a maintainer. elastic@freebsd.org is a mailing list account and is supposed to be Elastic maintainers team but it is not much active. The best place to submit your patch for port upgrade is PR in bugzilla. Please submit it there: https://bugs.freebsd.org/bugzilla/enter_bug.cgi?product=Ports%20%26%20Packages&component=Individual%20Port%28s%29 If you tested it with poudriere testport attache log file too. I hope someone with commit bit will commit it soon. Thank you for your work in Beats upgrade to 7.5! Kind regards Miroslav Lachman